Merging main to resolve help doc build error #81365
Conversation
…-VacationDelegatePage Make `VacationDelegatePage` use new `SelectionListWithSections`
…-SearchMultipleSelectionPicker Make `SearchMultipleSelectionPicker` use new `SelectionListWithSections`
…-SearchSingleSelectionPicker Make `SearchSingleSelectionPicker` use new `SelectionListWithSections`
Fixed required columns list + Fixed parser for default sortBy and column name parsing
…dynamically-deep-compare Fix: Cannot navigate duplicated expenses via arrow keys
Add Esc key behavior to Reports search similar to SearchRouter
Update "use *" to "use ."
…D-for-transaction-threads Handle the preExistingReportID for transaction threads, message threads, and single expense reports
…mission fix: preserve navigation state when opening settings from Onfido permission flow
The DomainsEmptyStateComponent was using styles.hoveredComponentBG which maps to a darker shade (productLight300/productDark300). Changed to styles.highlightBG which maps to the standard cardBG color (productLight200/productDark200). Fixes #81180 Co-authored-by: Shawn Borton <[email protected]>
fix: distance rates not enabled while duplicating a workspace offline
fix: device back button doesn't close FAB menu
fix: remove missing description violation once turn off rule
…imated-421 [Pre RN 0.83] Update `react-native-reanimated`, `react-native-live-markdown` and `react-native-worklets` to the latest versions
[No QA] ai-reviewer: rule for independent components
Part 1: Refactor ConfirmModal usage to useConfirmModal in workspace feature pages
melvin-bot
bot
requested review from
JmillsExpensify
and removed request for
a team
|
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
stephanieelliott
merged commit dd52f8c
into
garrettmknight-patch-6
melvin-bot
bot
requested review from
chiragsalian and
mjasikowski
and removed request for
a team
|
@mjasikowski @chiragsalian One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Your New Help changes have been deployed to https://59ccdd16.newhelp.pages.dev ⚡️ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| **Note:** Early cancellations aren’t available to all customers. | ||
| **Note:** This action is permanent and cannot be undone. | ||
|
|
||
| **ADD A SCREENSHOT HERE.** Suggestion: Deleting a workspace via the three-dot menu in the Workspaces tab. |
There was a problem hiding this comment.
Missing implementation: This placeholder text should be replaced with an actual screenshot showing how to delete a workspace via the three-dot menu. Placeholders reduce the article's usefulness and AI readiness.
| # Delete a Workspace | ||
| ## How to transfer billing ownership in Expensify | ||
|
|
||
| To transfer billing responsibility to another **Workspace Admin**, ask that member to [follow these steps to transfer billing ownership](LINK). |
There was a problem hiding this comment.
Broken link: "(LINK)" is a placeholder and should be replaced with the actual URL to the transfer billing ownership instructions. Broken links harm both user experience and AI readiness.
|
|
||
| If you're blocked from updating billing settings, canceling early, or deleting a workspace, it's likely because you’re not the billing owner. | ||
|
|
||
| If you are a Workspace Admin, you can transfer billing ownership to yourself by following the steps to [transfer billing ownership](LINK). |
There was a problem hiding this comment.
Broken link: "(LINK)" is a placeholder and should be replaced with the actual URL to the transfer billing ownership instructions. Broken links harm both user experience and AI readiness.
|
|
||
| {:width="100%"} | ||
|
|
||
| assets/images/ExpensifyHelp-WorkspaceSubmissions_Classic.png |
There was a problem hiding this comment.
Formatting violation: This line appears to be orphaned content that should either be removed or properly formatted. It looks like leftover text from editing that doesn't belong in the published article.
HelpDot Documentation ReviewOverall AssessmentThis PR contains a merge of main branch that includes 10 documentation files with a mix of new articles, significant updates, and minor corrections. The documentation changes demonstrate strong attention to detail with well-structured content, clear AI-ready metadata, and consistent formatting. Most files follow HelpDot standards closely, though a few areas need attention. Scores Summary
Key FindingsPositive Aspects:
Issues Requiring Attention:
Minor Style Observations:
RecommendationsPriority 1 (Must Fix):
Priority 2 (Should Fix): Priority 3 (Nice to Have): Files Reviewed
Overall, this documentation update represents strong work with clear improvements to structure, searchability, and user guidance. Addressing the priority items will bring these articles to publication-ready quality. |
|
|
||
| Expenses with violations—like missing receipts, incorrect categories, or amounts over Workspace limits—won’t be submitted. They’re removed from the current report and moved to a new open report. Once the violation is fixed, they’ll be submitted on the next scheduled date. | ||
|
|
||
| ## Why are reports still submitting automatically after disabling Submissions |
There was a problem hiding this comment.
Readability violation: This heading is missing a question mark. FAQ headings should be formatted as complete questions. Change to: "Why are reports still submitting automatically after disabling Submissions?"
| @@ -130,7 +130,7 @@ Enter any of the following formulas into the Formula field for each column. Be s | |||
| | {report:policyName} | Same as the workspace name. Policy is an older term for workspace.| | |||
There was a problem hiding this comment.
Terminology violation: Use "workspace" instead of "policy" to match Expensify terminology standards. The term "policyName" should be updated to reference "workspaceName" or include a note that "policy" is deprecated terminology.
|
|
||
| This feature helps prevent policy violations and ensures accurate expense tracking from the moment of upload. | ||
| - Forward your digital receipts to [email protected]. | ||
| - Text a receipt photo to 47777 (US numbers only). Make sure you [add your phone number as a contact method to Expensify](https://new.expensify.com/settings/profile/contact-methods). |
There was a problem hiding this comment.
Readability violation: "Make sure you" is verbose phrasing. Simplify to: "First, [add your phone number as a contact method to Expensify]..." This improves scannability and reading level.
|
|
||
| If you have a private domain (e.g., yourcompany.com), you can claim and verify it in Expensify to manage employee permissions and enable additional security features. | ||
|
|
||
| # What you can do with a claimed and verified domain |
There was a problem hiding this comment.
Missing breadcrumb path: This article should include a breadcrumb path below the H1 to improve navigation context and AI readiness. Add: "Settings > Workspaces > Domains" or similar navigation path.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
20 participants
N/A
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari