-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Refactor ConfirmModal usage to useConfirmModal in Money Request pages #80902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9c9002ed8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx
Outdated
Show resolved
Hide resolved
|
@nkdengineer |
|
No product considerations, removing my review |
|
@ZhenjaHorbach It's ready now. |
|
@nkdengineer |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-02-05.16.00.19.mov2026-02-05.16.02.52.movAndroid: mWeb Chrome2026-02-05.16.08.23.mov2026-02-05.16.09.50.mov2026-02-05.16.10.46.moviOS: HybridApp2026-02-05.16.00.19.mov2026-02-05.16.02.52.moviOS: mWeb SafariMacOS: Chrome / Safari2026-02-03.11.02.03.mov2026-02-03.11.03.51.mov2026-02-03.11.05.09.mov2026-02-03.11.12.41.mov |
|
We can see Not here page after these steps on mobile MoneyRequestReceiptView.tsx 2026-02-05.16.08.23.mov |
@ZhenjaHorbach Does this happen on latest main? |
@ZhenjaHorbach Fixed. |
|
Still can reproduce on iOS web 2026-02-12.13.55.31.mov |
|
@nkdengineer |
|
@ZhenjaHorbach I can't reproduce this issue in our PR. And again, Does this happen on latest main? Screen.Recording.2026-02-13.at.10.16.25.movScreen.Recording.2026-02-13.at.10.13.41.mov |

Explanation of Change
Refactor ConfirmModal usage to useConfirmModal in Money Request pages
Fixed Issues
$ #76694
PROPOSAL:
Tests
Precondition: Workspace approval mode is
DYNAMIC_EXTERNALOffline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-29.at.23.39.38.mov
Android: mWeb Chrome
Screen.Recording.2026-01-29.at.23.35.42.mov
iOS: Native
Screen.Recording.2026-01-29.at.23.36.08.mov
iOS: mWeb Safari
Screen.Recording.2026-01-29.at.23.37.55.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-29.at.23.28.44.mov
Screen.Recording.2026-01-29.at.23.30.15.mov
Screen.Recording.2026-01-29.at.23.30.30.mov
Screen.Recording.2026-01-29.at.23.32.22.mov