Add 'Got it' modal when deleting a workspace with existing cards

[huult]

Explanation of Change

Fixed Issues

$ #79022
PROPOSAL: #79022 (comment)

Tests

Same QA step

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Preconditions: The workspace has issued an Expensify Card to the member.

1. Open the Expensify app.
2. Go offline.
3. Navigate to the Workspace Overview or Workspace List.
4. Click the More button.
5. Select Delete.
6. Click the Delete button.
7. Verify that the “Can’t delete” warning modal with a “Got it” button is displayed while offline.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-29.at.12.01.18.mp4

Android: mWeb Chrome

Screen.Recording.2026-01-29.at.12.02.21.mp4

iOS: Native

Screen.Recording.2026-01-29.at.12.04.27.mp4

iOS: mWeb Safari

Screen.Recording.2026-01-29.at.12.05.52.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-01-29.at.11.58.35.mp4

[melvin-bot]

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f495da82dc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/Policy/Policy.ts	36.53% <66.66%> (+0.39%)	⬆️
src/pages/workspace/WorkspacesListPage.tsx	61.29% <33.33%> (-0.35%)	⬇️
src/pages/workspace/WorkspaceOverviewPage.tsx	0.00% <0.00%> (ø)
... and 14 files with indirect coverage changes

[chatgpt-codex-connector]

💡 Codex Review

App/src/pages/workspace/WorkspacesListPage.tsx

Lines 245 to 249 in 45a3728

	deleteWorkspace({
	policyID: policyIDToDelete,
	activePolicyID,
	policyName: policyNameToDelete,
	lastAccessedWorkspacePolicyID,

Skip queuing delete when offline card deletion is blocked

confirmDelete always calls deleteWorkspace(...) before the offline/hasWorkspaceDeleteErrorOffline guard returns, so the delete is still queued and optimistic delete updates (pendingAction DELETE / report archiving) are applied even though the UI immediately shows the offline error. If the request later runs when reconnecting (or if cards are removed), the workspace can be deleted without an explicit retry, or reports can remain archived while offline. Short‑circuit before calling deleteWorkspace or cancel the queued write when showing the offline error modal.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[huult]

@Pujan92 This PR is ready.

[joekaufmanexpensify]

@huult why are we showing this failure modal that prevents deleting Expensify Cards in the first place, right after a modal saying that deleting the workspace will remove cards? I thought we supported removing the Expensify Card feed when deleting a workspace?

[huult]

@joekaufmanexpensify Yes, after you pointed this out, I also agree that it looks odd.
However, at the moment the backend does not allow deleting a workspace if it has issued an Expensify Card.
I think we should block the deletion earlier and show a “Got it” modal at the first step, instead of allowing the user to proceed and then showing a failure modal. What do you think?

Alternatively, we could update the backend to allow deleting the workspace and remove all Expensify Card feeds, as described in the first modal.

[joekaufmanexpensify]

Hm, do you know if that changed recently? We definitely used to support deleting a workspace with Expensify Cards if there are no unbilled transactions. cc @mountiny

[huult]

@joekaufmanexpensify I’m not sure. I think we should ask the backend team for more details.

Screen.Recording.2026-02-04.at.09.29.23.mov

[mountiny]

I dont really clearly remember where we put the line, but I know that there were some restrictions in place when trying to delete workspace.

I recommend to make sure to align on the expected results exactly and then we can create Internal issue to look into this and make sure the DeletePolicy flow does that

[huult]

cc @joekaufmanexpensify

[joekaufmanexpensify]

I dont really clearly remember where we put the line, but I know that there were some restrictions in place when trying to delete workspace.

My recollection is that we allowed it if the Expensify Card feed didn't have any unbilled transactions. But you're saying that this isn't possible in any situation right now yeah @huult ?

[huult]

@joekaufmanexpensify

Screen.Recording.2026-02-10.at.16.03.22.mov

1 If we only enable the card feature but do not issue or add any cards, the workspace can be deleted.

Screen.Recording.2026-02-10.at.16.06.01.mov

2 If a company card has been added, the workspace can still be deleted.

Screen.Recording.2026-02-10.at.16.38.09.mov

3 If a company card has been added and assigned, the workspace can still be deleted.

Screen.Recording.2026-02-10.at.17.05.17.mov

4 If an expense card has been added and issued, the workspace can still be deleted.

Screen.Recording.2026-02-10.at.17.10.42.mov

@joekaufmanexpensify Just to double-check: when the card feed connection is broken, deleting the workspace is blocked and we show the error message “Your company still has open Expensify Cards.”

However, when a card has been added and issued (and the feed is connected), the workspace can still be deleted like videos above.

[joekaufmanexpensify]

Got it. Yeah, it's expected that you can delete the workspace when there are company cards. That's what the warning modal is for. For Expensify Cards, I'd expect that you'd be able to delete the workspace still as long as there are no Expensify Card transactions we haven't billed for yet. And we'd just close the cards if the user did that. It definitely used to work that way, but must've been changed.

It'd also be fine with me to just prevent deleting workspace when there are Expensify Cards. But why show the warning modal at all then? If they can't delete the workspace, we should just show an error explaining that right when they try to delete. That warning should also explain how to resolve that, and ideally link them to their concierge chat to get the cards removed.

[huult]

@joekaufmanexpensify You might be misunderstanding this, because in the cases I listed, the workspace can be deleted. There is only one case where the workspace cannot be deleted: when the card feed connection is broken. In that case, deletion is not allowed.

I think we should only show the “Got it” modal when the user is offline and the workspace has a broken card feed connection.

[joekaufmanexpensify]

Ah, sorry. I think I got confused about how the videos were posted. Yeah, throwing an error that you can't delete a workspace because there are open Expensify Cards when there's a broken connection error on an unrelated company cards feed doesn't really make sense to me.

[huult]

@joekaufmanexpensify Yes, I think the same. This error message isn’t correct. We should update the copy to say that the card feed is broken and the workspace can’t be deleted. If so, I think we should also update the error message on the backend.