Fix: Report loads infinitely after deleting split and opening the empty report #80216
Fix: Report loads infinitely after deleting split and opening the empty report #80216cretadn22 wants to merge 10 commits intoExpensify:mainfrom
Conversation
… optimistic, success, and failure data accordingly.
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Can we add a unit test here? |
… optimistic, success, and failure data accordingly.
…lt value is used when undefined
|
@blimpich I added tests to cover the new changes |
|
Thank you! |
|
backend changes were merged, currently waiting on it to be deployed, but at the absolute latest this should be ready to test with backend changes by tomorrow |
|
Backend is deployed, lets move forward 👍. cc: @hoangzinh |
|
@cretadn22, It seems the PR title is incomplete. Could you please update it? Thank you! |
|
Bug: App displays infinite loading after deleting a split expense
Expected: App should only delete the split expense in step 6 and display manual expense in step 4 Actual: App deletes the above split expense and manual expense. Also it displays infinite loading Screen.Recording.2026-02-01.at.16.00.51.mov |
|
@cretadn22 I found it's weird when I follow testing steps:
After step 9, I only see 1 money report of a split expense. Repeat step 10 and 11, it displays "Not here" page Screen.Recording.2026-02-01.at.22.55.23.mov |
|
@hoangzinh I can't reproduce both your bugs on my end Screen.Recording.2026-02-03.at.19.12.51.mp4 |
@cretadn22 can you test when offline? I just updated steps here #80216 (comment) |
|
@cretadn22 can you share a recording on your end about this bug? I can help you reproduce it. |
|
This bug: #80216 (comment) This bug is caused by an incorrect condition. We should only remove the report when the deleted transaction is the last remaining transaction in that report. @hoangzinh Pushed a fix |
|
Can't reproduce #80216 (comment) Screen.Recording.2026-02-04.at.21.18.01.mp4 |
…t report and if it's the last transaction in the current report
It seems to be fixed somewhere. |
|
@cretadn22 I found another bug: report preview is still clickable after delete when offline. You can check behavior when delete a normal expense in offline. Screen.Recording.2026-02-06.at.05.55.06.mov |
|
Hi @blimpich Just in case the message gets lost in the flood, I would like to hear your opinion on this: #80216 (comment) |
|
Responded 👍 |
|
@hoangzinh I fixed this bug by adding pendingAction to report action |
Explanation of Change
Fixed Issues
$ #75783
PROPOSAL: #75783 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-08.at.14.53.29.mov
Android: mWeb Chrome
Screen.Recording.2026-02-08.at.13.20.34.mov
iOS: Native
Screen.Recording.2026-02-08.at.14.58.15.mov
iOS: mWeb Safari
Screen.Recording.2026-02-08.at.15.21.17.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-08.at.13.16.13.mov