Skip to content

Fix: Report loads infinitely after deleting split and opening the empty report #80216

Open
cretadn22 wants to merge 10 commits intoExpensify:mainfrom
cretadn22:fix/infinite-loading-empty-expense-report
Open

Fix: Report loads infinitely after deleting split and opening the empty report #80216
cretadn22 wants to merge 10 commits intoExpensify:mainfrom
cretadn22:fix/infinite-loading-empty-expense-report

Conversation

@cretadn22
Copy link
Contributor

@cretadn22 cretadn22 commented Jan 22, 2026

Explanation of Change

Fixed Issues

$ #75783
PROPOSAL: #75783 (comment)

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Create an expense
  4. Open the expense report
  5. Click More > Split
  6. Click Save
  7. Open any split
  8. Click Report field > Create report
  9. Go back to workspace chat
  10. Right click on the report with one split > Delete
  11. Delete the report
  12. The report is deleted
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-02-08.at.14.53.29.mov
Android: mWeb Chrome
Screen.Recording.2026-02-08.at.13.20.34.mov
iOS: Native
Screen.Recording.2026-02-08.at.14.58.15.mov
iOS: mWeb Safari
Screen.Recording.2026-02-08.at.15.21.17.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-08.at.13.16.13.mov

… optimistic, success, and failure data accordingly.
@cretadn22 cretadn22 requested review from a team as code owners January 22, 2026 12:35
@melvin-bot melvin-bot bot requested review from heyjennahay and hoangzinh and removed request for a team January 22, 2026 12:35
@melvin-bot
Copy link

melvin-bot bot commented Jan 22, 2026

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from a team and blimpich and removed request for a team January 22, 2026 12:35
@melvin-bot
Copy link

melvin-bot bot commented Jan 22, 2026

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@cretadn22 cretadn22 changed the title Implement logic to handle split expenses in the same report, updating… [Hold Backend] Implement logic to handle split expenses in the same report, updating… Jan 22, 2026
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/actions/IOU/Split.ts 80.59% <100.00%> (+12.91%) ⬆️
... and 10 files with indirect coverage changes

@blimpich
Copy link
Contributor

Can we add a unit test here?

@cretadn22
Copy link
Contributor Author

@blimpich I added tests to cover the new changes

@blimpich
Copy link
Contributor

Thank you!

@blimpich
Copy link
Contributor

backend changes were merged, currently waiting on it to be deployed, but at the absolute latest this should be ready to test with backend changes by tomorrow

@blimpich blimpich changed the title [Hold Backend] Implement logic to handle split expenses in the same report, updating… Implement logic to handle split expenses in the same report, updating… Jan 30, 2026
@blimpich
Copy link
Contributor

Backend is deployed, lets move forward 👍. cc: @hoangzinh

@hoangzinh
Copy link
Contributor

@cretadn22, It seems the PR title is incomplete. Could you please update it? Thank you!

@hoangzinh
Copy link
Contributor

hoangzinh commented Feb 1, 2026

Bug: App displays infinite loading after deleting a split expense

  1. Create an empty report
  2. Create an expense
  3. Split that expense
  4. Create another manual expense
  5. Go offline
  6. Move 1 split expense to new report
  7. Delete the last split expense in report in step (1)

Expected: App should only delete the split expense in step 6 and display manual expense in step 4

Actual: App deletes the above split expense and manual expense. Also it displays infinite loading

Screen.Recording.2026-02-01.at.16.00.51.mov

@hoangzinh
Copy link
Contributor

@cretadn22 I found it's weird when I follow testing steps:

  1. Go back to workspace chat

After step 9, I only see 1 money report of a split expense. Repeat step 10 and 11, it displays "Not here" page

Screen.Recording.2026-02-01.at.22.55.23.mov

@cretadn22 cretadn22 changed the title Implement logic to handle split expenses in the same report, updating… Fix: Report loads infinitely after deleting split and opening the empty report Feb 2, 2026
@cretadn22
Copy link
Contributor Author

@hoangzinh I can't reproduce both your bugs on my end

Screen.Recording.2026-02-03.at.19.12.51.mp4

@hoangzinh
Copy link
Contributor

@hoangzinh I can't reproduce both your bugs on my end

@cretadn22 can you test when offline? I just updated steps here #80216 (comment)

@hoangzinh
Copy link
Contributor

@cretadn22 can you share a recording on your end about this bug? I can help you reproduce it.

@cretadn22
Copy link
Contributor Author

cretadn22 commented Feb 4, 2026

This bug: #80216 (comment)

This bug is caused by an incorrect condition. We should only remove the report when the deleted transaction is the last remaining transaction in that report.

@hoangzinh Pushed a fix

@cretadn22
Copy link
Contributor Author

Can't reproduce #80216 (comment)

Screen.Recording.2026-02-04.at.21.18.01.mp4

@hoangzinh
Copy link
Contributor

Can't reproduce #80216 (comment)

It seems to be fixed somewhere.

@hoangzinh
Copy link
Contributor

@cretadn22 I found another bug: report preview is still clickable after delete when offline. You can check behavior when delete a normal expense in offline.

Screen.Recording.2026-02-06.at.05.55.06.mov

@hoangzinh
Copy link
Contributor

Hi @blimpich Just in case the message gets lost in the flood, I would like to hear your opinion on this: #80216 (comment)

@blimpich
Copy link
Contributor

blimpich commented Feb 5, 2026

Responded 👍

@cretadn22
Copy link
Contributor Author

@hoangzinh I fixed this bug by adding pendingAction to report action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants