-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Get rid of system message when moving expense from personal space #79199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
| ): ReportAction { | ||
| const isFromPersonalSpace = originalReportID === CONST.REPORT.UNREPORTED_REPORT_ID; | ||
| const reportName = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${originalReportID}`]?.reportName ?? ''; | ||
| const url = isFromPersonalSpace ? getReportURLForCurrentContext(findSelfDMReportID()) : getReportURLForCurrentContext(originalReportID); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also remove isFromPersonalSpace condition if it's safe?
(this logic was introduced in #71220 for reference)
Let's leave as is for now.
Explanation of Change
Do not render MOVED_TRANSACTION actions that originate from the personal space by updating the visibility guard in src/libs/ReportActionsUtils.ts. And some cleanup related to this.
Fixed Issues
$ #78025
PROPOSAL: #78025 (comment)
Tests
Offline tests
QA Steps
Same.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-09.at.5.55.58.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-01-09.at.5.53.05.PM.mov
iOS: Native
Screen.Recording.2026-01-09.at.5.54.24.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-01-09.at.5.51.42.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-09.at.5.48.16.PM.mov