Skip to content

Conversation

@daw538
Copy link
Contributor

@daw538 daw538 commented Oct 7, 2025

Some of the test cases in Isca make use of a smoothed/filtered topography file constructed from the global topography ERA-Interim datasets. The original script used to create such files was never included into Isca's main repo and relies on methods that are either outdated (e.g. written in python2) or not broadly comparable across a range of hardware. The script provided in this PR provides a more updated but equivalent method for constructing files with a range of resolutions for Isca's different use cases.

@daw538
Copy link
Contributor Author

daw538 commented Oct 7, 2025

Here is a comparison of a topography file that previously existed made using the old script with one from the new script in this PR. There are numerical differences between the two however the maps look almost identical (using the same colourbar which I forgot to include).

method_comparison

Plus a demonstration of the function as applied for a range of resolutions used in Isca:

tnum_comparison

@sit23
Copy link
Contributor

sit23 commented Oct 8, 2025

This looks great to me @daw538 - thanks so much for re-writing this and getting it in. I don't have any particular comments, other than that I'm happy for it to go in the master whenever you're ready.

@sit23 sit23 self-requested a review October 8, 2025 09:06
daw538 and others added 3 commits October 8, 2025 10:41
Added README.md with information on topography source files and usage.
…lso provides a cleaner interface (though same output) as old script
@daw538 daw538 requested a review from sit23 October 8, 2025 10:03
Copy link
Contributor

@sit23 sit23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made one tiny comment on the readme. But it looks great! I'm happy for it to be merged with that tiny tweak.

@daw538
Copy link
Contributor Author

daw538 commented Oct 23, 2025

Thanks @sit23 for the comment. I've edited the README as suggested.

@daw538 daw538 merged commit 1389820 into ExeClim:master Oct 23, 2025
1 check passed
@daw538 daw538 deleted the era5_topography branch October 23, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants