Open
Conversation
maddie480-bot
added
the
1: review needed
Member
|
Doesn't this conflict with #1005? |
Contributor
Author
It's not the same "nest" way as it, it just focus another menu when entering a "submenu". Since we have true nested submenu supports in it, I can then base this implement on it later🤔 |
maddie480-bot
added
0: draft
Contributor
Author
|
Tried using 'true' submenus, but it looks a little ugly. I personally would prefer this previous implement. |
maddie480-bot
added
1: review needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1015
This pr also fix submenus not being expanded by its items. (It's calculated but not used somehow, I don't know much about the details 🤔)
Absolutely this will make search box a bit useless, or should we have a feature that search box can search into nested menus?