fix: wait-for-header waits forever for version > 4

[sveitser]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @sveitser, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the wait-for-header script where it would indefinitely wait for an exact minor version match, even if a newer version was already available. The change modifies the version comparison logic to correctly recognize and proceed when the detected minor version is greater than or equal to the target, ensuring the script terminates as expected.

Highlights

• Bug Fix: The wait-for-header script's wait_for_version function has been corrected to properly handle scenarios where the detected minor version is greater than or equal to the target minor version. Previously, it would only exit if the versions were an exact match, leading to indefinite waiting if a newer version was already present.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request provides a good fix for a potential issue in the wait-for-header script. Previously, the script waited for an exact version match, which could lead to an infinite loop if that version was skipped. By changing the comparison to 'greater than or equal to' (-ge), the script is now more robust and will correctly handle cases where the detected version is newer than the target. The updated log message is also a nice improvement for clarity. The change is correct and well-implemented.