Skip to content

Conversation

@sveitser
Copy link
Collaborator

Add default-features = false to sequencer dependencies in:

  • slow-tests
  • tests
  • light-client-query-service
  • light-client (dev-deps)
  • crates/builder (dev-deps)

This prevents feature unification from enabling all sequencer version features (fee, pos, drb-and-header, da-upgrade) when building with specific features only.

Add `default-features = false` to sequencer dependencies in:
- slow-tests
- tests
- light-client-query-service
- light-client (dev-deps)
- crates/builder (dev-deps)

This prevents feature unification from enabling all sequencer version
features (fee, pos, drb-and-header, da-upgrade) when building with
specific features only.
@gemini-code-assist
Copy link

Summary of Changes

Hello @sveitser, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the dependency management for the sequencer crate by explicitly setting default-features = false in its various dependent Cargo.toml files. This crucial adjustment prevents unintended feature unification, ensuring that only the features explicitly requested for sequencer are compiled, thereby maintaining build integrity and avoiding unnecessary feature bloat.

Highlights

  • Dependency Feature Management: Explicitly disabled default features for the sequencer dependency in several Cargo.toml files across various crates (slow-tests, tests, light-client-query-service, light-client, and crates/builder).
  • Preventing Feature Unification Issues: This change addresses an issue where feature unification could inadvertently enable all sequencer version features (e.g., fee, pos, drb-and-header, da-upgrade) even when only specific features were intended to be built.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly disables default features for the sequencer dependency in several crates to prevent unintended feature unification. The changes are correct and align with the PR's goal. I've added one comment about a small, unrelated change. As a suggestion for a potential follow-up, you might want to check if espresso-dev-node/Cargo.toml also needs default-features = false for its sequencer dependency.

Comment on lines 144 to +145
memoize = { version = "0.4", features = ["full"] }
moka = { version = "0.12.12", features = ["future"] }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This reordering of dependencies seems unrelated to the main purpose of this pull request, which is to disable default features. To keep commits focused and atomic, it's generally better to move such stylistic changes to a separate PR.

@sveitser sveitser enabled auto-merge (squash) January 30, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants