-
Notifications
You must be signed in to change notification settings - Fork 168
feat: mass (un)delegation in stake table contract #3825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sveitser
wants to merge
10
commits into
main
Choose a base branch
from
ma/staking-cli-mass-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc: move demo staking to developer docs file
Pre-sign all transactions and save to a log file for reliable resume. Execute phases in order (FundEth → FundEsp → Approve → Delegate) with two-level flow control: outer semaphore limits unconfirmed txs, inner semaphore limits RPC concurrency. Single-sender phases use batches of 64 to avoid geth txpool drops. Changes: - Add TxLog for pre-signed transaction storage and recovery - Add TxPhase enum for ordered phase execution - Add map_concurrent utility for bounded parallel execution - Replace --batch-size/--delay with --log-path/--concurrency - Add DeployContracts demo command (testing feature)
lukaszrzasik
approved these changes
Jan 24, 2026
Collaborator
Author
|
/gemini review |
- Add apply_with_backpressure method for concurrent transaction execution with configurable concurrency and proper phase synchronization - Add concurrency parameter to demo stake, delegate, undelegate, and churn - Add stress tests running on Reth with 1s block time (10k delegators) - Refactor TestSystem to support external RPC endpoints via deploy_to_external - Add pre-execution balance checks for ESP and ETH to fail fast - Tune tx_log parameters: reduce MAX_UNCONFIRMED to 1000, increase CONFIRMATION_TIMEOUT to 180s, add 100 gwei gas floor - Add RethContainer helper for running Reth in Docker during tests
Log submission progress every 100 transactions and at completion to provide visibility during large batch operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO