add error on thrift version mismatch, add rebuild script#4806
Open
feyruzb wants to merge 2 commits intoEricsson:masterfrom
Open
add error on thrift version mismatch, add rebuild script#4806feyruzb wants to merge 2 commits intoEricsson:masterfrom
feyruzb wants to merge 2 commits intoEricsson:masterfrom
Conversation
feyruzb
force-pushed
the
chore/thrift-version-check-on-make-package
branch
from
16648d5 to
e659203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an automated check to ensure that the CodeChecker API version in the source matches the version installed in the project's virtual environment. If a mismatch is detected, the build process will now fail with a clear error message and instructions for resolving the issue. Additionally, a new script has been added to simplify rebuilding the Thrift API and virtual environment when needed.
API version consistency enforcement:
Makefileto extract the API version from the source (setup.py) and from the installed package in eithervenvorvenv_dev(codechecker-api).check_api_versiontarget in theMakefilethat compares the source and virtual environment API versions, halting the build with an error and instructions if they do not match.packagetarget in theMakefileto run thecheck_api_versionstep before packaging, ensuring version consistency is always verified.Developer tooling:
web/api/completly-rebuild-thrift.sh, which automates rebuilding the Thrift API, cleaning previous builds, recreating the virtual environment, and rebuilding the package. This script provides clear messaging and usage instructions for developers.