Improve Binary Serialization in the Code Generator #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm a big fan of the Code Generator tool, but I noticed the all-in-one pages serialize the game as a JSON array, which can get kind of chunky. This PR swaps the JSON for a base64 string, bringing a `53.35mb` .html down to `21.85mb`. This should help with storage and load-times. Zipping the .html afterwards brings the whole thing down to within 10% of the original game size. bytes <-> base64 conversions adopted from examples on this page: https://developer.mozilla.org/en-US/docs/Web/API/Window/btoa
✅ Deploy Preview for emulatorjs-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Hmm, I notice the .zip files this tool outputs are getting a 0% compression ratio... perhaps we can do better... |
Contributor
Author
|
Hmmm, I can add a bit of compression before applying the base64 encoding (Final .html size goes from |
zalo
added a commit
to zalo/emulatorjs.org
that referenced
this pull request
May 8, 2025
This PR adds compression to the generated .html files using the browser's built-in gzip compression/decompression routines. This brings what would have been a `53.35mb` .html on master (or a `21.85mb` .html with EmulatorJS#58 ) down to `16.32mb`. This further compresses down to `12mb` if zipped. Due to the async call needed for this, I made this a separate PR since the structure of the generated .html has changed to only load the emulator after the game data has been decompressed. This is incompatible with the non-single-file-packing code, so it has been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a big fan of the Code Generator tool, but I noticed the all-in-one pages serialize the game as a JSON array, which can get kind of chunky.
This PR swaps the JSON for a base64 string, bringing a
53.35mb.html down to21.85mb. This should help with storage and load-times.Zipping the .html afterwards brings the whole thing down to within 10% of the original game size, which is nice if your static file server supports archiving like this.
bytes <-> base64 conversions adopted from examples on this page: https://developer.mozilla.org/en-US/docs/Web/API/Window/btoa