Skip to content

Translate Tool #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ethanaobrien merged 8 commits into from
May 1, 2025
Merged

Translate Tool #56

ethanaobrien merged 8 commits into from
May 1, 2025

Conversation

@allancoding
Copy link
Member

@allancoding allancoding commented Apr 28, 2025

  • Added Translate Tool.
  • Fixed naming with the code generator.
  • Optimized the vue pages

@netlify
Copy link

netlify bot commented Apr 28, 2025 •
edited
Loading

✅ Deploy Preview for emulatorjs-org ready!

Name Link
🔨 Latest commit c945799
🔍 Latest deploy log https://app.netlify.com/sites/emulatorjs-org/deploys/6812c048a26a96000811703f
😎 Deploy Preview https://deploy-preview-56--emulatorjs-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@allancoding
Copy link
Member Author

allancoding commented Apr 28, 2025

This should not be merged until EmulatorJS/EmulatorJS#987 is merged.
Uses new localisation file in https://cdn.emulatorjs.org/latest/data/localization/en-US.json

@allancoding
Copy link
Member Author

allancoding commented Apr 29, 2025

Ready to be merged

ethanaobrien
ethanaobrien requested changes Apr 30, 2025
View reviewed changes
Copy link
Member

@ethanaobrien ethanaobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull upstream

@allancoding allancoding requested a review from ethanaobrien May 1, 2025 00:31
ethanaobrien
ethanaobrien approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@ethanaobrien ethanaobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review and merge @michael-j-green or @S-Coding23

michael-j-green
michael-j-green approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@michael-j-green michael-j-green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ethanaobrien ethanaobrien merged commit f98628b into main May 1, 2025
8 checks passed
@allancoding allancoding deleted the translate branch May 1, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanaobrien ethanaobrien ethanaobrien approved these changes

@michael-j-green michael-j-green michael-j-green approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@allancoding @ethanaobrien @michael-j-green