Skip to content

Peer storage enhancements #8422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adi2011 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Peer storage enhancements #8422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88ad903
chanbackup: Store the latest recvd peer storage only
adi2011 Jul 22, 2025
8d8ab1b
chanbackup: make getemergencyrecoverdata rpc more verbose
adi2011 Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .msggen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1901,6 +1901,8 @@
"FundPsbt.reservations[]": 6
},
"GetemergencyrecoverdataResponse": {
"GetEmergencyRecoverData.backed_up_channel_ids[]": 3,
"GetEmergencyRecoverData.can_create_penalty": 2,
"GetEmergencyRecoverData.filedata": 1
},
"GetinfoAddress": {
Expand Down Expand Up @@ -7844,6 +7846,14 @@
"added": "v24.11",
"deprecated": null
},
"GetEmergencyRecoverData.backed_up_channel_ids[]": {
"added": "v24.11",
"deprecated": null
},
"GetEmergencyRecoverData.can_create_penalty": {
"added": "v24.11",
"deprecated": null
},
"GetEmergencyRecoverData.filedata": {
"added": "v24.11",
"deprecated": null
Expand Down
2 changes: 2 additions & 0 deletions cln-grpc/proto/node.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions cln-grpc/src/convert.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions cln-rpc/src/model.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 18 additions & 1 deletion contrib/msggen/msggen/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14355,7 +14355,9 @@
},
"response": {
"required": [
"filedata"
"filedata",
"can_create_penalty",
"backed_up_channel_ids"
],
"additionalProperties": false,
"properties": {
Expand All @@ -14364,6 +14366,21 @@
"description": [
"The raw, hex-encoded, emergency.recover file"
]
},
"can_create_penalty": {
"type": "boolean",
"description": [
"If false, you are using legacy file version, which can not create penalty transactions, kindly delete emergency.recover and restart the node!"
]
},
"backed_up_channel_ids": {
"type": "array",
"items": {
"type": "hex",
"description": [
"Channel IDs of channels backed up inside emergency.recover"
]
}
}
}
},
Expand Down
2,040 changes: 1,020 additions & 1,020 deletions contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions contrib/pyln-testing/pyln/testing/grpc2py.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,8 @@ def emergencyrecover2py(m):

def getemergencyrecoverdata2py(m):
return remove_default({
"backed_up_channel_ids": [hexlify(m.backed_up_channel_ids) for i in hexlify(m.backed_up_channel_ids)], # ArrayField[primitive] in generate_composite
"can_create_penalty": m.can_create_penalty, # PrimitiveField in generate_composite
"filedata": hexlify(m.filedata), # PrimitiveField in generate_composite
})

Expand Down
19 changes: 18 additions & 1 deletion doc/schemas/getemergencyrecoverdata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
},
"response": {
"required": [
"filedata"
"filedata",
"can_create_penalty",
"backed_up_channel_ids"
],
"additionalProperties": false,
"properties": {
Expand All @@ -22,6 +24,21 @@
"description": [
"The raw, hex-encoded, emergency.recover file"
]
},
"can_create_penalty": {
"type": "boolean",
"description": [
"If false, you are using legacy file version, which can not create penalty transactions, kindly delete emergency.recover and restart the node!"
]
},
"backed_up_channel_ids": {
"type": "array",
"items": {
"type": "hex",
"description": [
"Channel IDs of channels backed up inside emergency.recover"
]
}
}
}
},
Expand Down
Loading
Loading