Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const toAddress = await getAddress( | ||
| toWallet, | ||
| toWallet.currencyInfo.pluginId === 'zcash' | ||
| ? 'transparentAddress' | ||
| : undefined |
There was a problem hiding this comment.
The new transparent-address handling for ZEC destinations (lines 388‑392) never runs because checkInvalidCodes is still called earlier with INVALID_CURRENCY_CODES.to.zcash = ['ZEC'] (lines 129‑135), so any swap targeting ZEC throws SwapCurrencyError before quoting. As a result the commit’s intended support for Maya ZEC receives remains blocked; remove the invalid-code entry or gate it to paths that truly need to be disallowed.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is valid, it's impossible to receive ZEC as-is
There was a problem hiding this comment.
Right this should be removed, to zec not supported.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const toAddress = await getAddress( | ||
| toWallet, | ||
| toWallet.currencyInfo.pluginId === 'zcash' | ||
| ? 'transparentAddress' | ||
| : undefined |
There was a problem hiding this comment.
This is valid, it's impossible to receive ZEC as-is
| } | ||
|
|
||
| // Convert native to a decimal string per ZIP-321 spec | ||
| const multiplier = |
There was a problem hiding this comment.
Use the wallet's nativeToDenomination method instead
| ) | ||
|
|
||
| // Encode memo per ZIP-321 as base64url (unpadded). | ||
| const memoBase64Url = Buffer.from(memo, 'utf8') |
There was a problem hiding this comment.
Instead of handrolling use a library like base64url
|
|
||
| // ZIP-321 requires grouping parameters by payment using paramindex. | ||
| // Payment 0 (unindexed): transparent vault recipient & swap amount. | ||
| // Payment 1 (indexed .1): shielded memo recipient, memo, and tiny amount to preserve memo. |
There was a problem hiding this comment.
The comment suggests sending a tiny amount to Payment 1 but mount.1 is 0
There was a problem hiding this comment.
Comment just needs to be updated. Impl is correct
|
|
||
| // Special-case ZEC: If inbound is transparent and memo is non-empty, | ||
| // build a ZIP-321 URI to satisfy Maya's requirements | ||
| if (fromWallet.currencyInfo.pluginId === 'zcash' && thorAddress != null) { |
There was a problem hiding this comment.
Move the zcash stuff into it's own else if (fromWallet.currencyInfo.pluginId === 'zcash') block. and then do the thorAddress check and copy any additional checks that the UTXO block is doing. While zcash is utxo based under the hood it really isn't treated as such in Edge so let's keep it separate
Jon-edge
force-pushed
the
jon/maya-zec
branch
from
826df00 to
1a59a57
Compare
Jon-edge
force-pushed
the
jon/maya-zec
branch
from
1a59a57 to
e0ebfa9
Compare
| ) | ||
|
|
||
| // Encode memo per ZIP-321 as base64url (unpadded). | ||
| const memoBase64Url = base64urlnopad.encode(utf8.decode(memo)) |
There was a problem hiding this comment.
Bug: Wrong utf8 method: decode vs encode for string
The code calls utf8.decode(memo) but memo is a string and utf8.decode expects a Uint8Array. The @scure/base library's utf8.decode converts UTF-8 bytes to string, while utf8.encode converts string to UTF-8 bytes. Since the intent is to convert the string memo to bytes for base64url encoding, this should use utf8.encode(memo) instead of utf8.decode(memo). This will cause ZEC swaps to fail at runtime.
There was a problem hiding this comment.
Looking at how @scure/base coders work:
decode = decode FROM the encoding representation → produces bytes
encode = encode TO the encoding representation → produces string
So for utf8:
utf8.decode(string) → Uint8Array (decodes the string into UTF-8 bytes)
utf8.encode(Uint8Array) → string (encodes bytes back to string)
The current code:
const memoBase64Url = base64urlnopad.encode(utf8.decode(memo))
Flow: string → utf8.decode() → Uint8Array → base64urlnopad.encode() → base64url string
This matches the original Buffer approach:
Buffer.from(memo, 'utf8') // string → bytes .toString('base64') // bytes → base64 string
The cursor bot comment is incorrect. The current code is right:
utf8.decode(memo) converts the string to bytes ✅
base64urlnopad.encode(...) converts bytes to base64url string ✅
2 participants
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Add Maya Protocol Zcash swap support using ZIP-321 with shielded memo config and ZEC mainnet transcription.
zcash -> ZECtoMAINNET_CODE_TRANSCRIPTION.asInboundAddressesto includeshielded_memo_configand fetch/storeunified_addressper chain.publicAddressto vault; passzip321UriinspendInfo.otherParams.@scure/basefor base64url/UTF-8 handling.Written by Cursor Bugbot for commit e0ebfa9. This will update automatically on new commits. Configure here.