Use tokenIds in place of currencyCodes#421
Merged
Conversation
swansontec
requested changes
Nov 26, 2025
src/swap/central/changehero.ts
Outdated
| const quoteAmount = | ||
| request.quoteFor === 'from' | ||
| ? await request.fromWallet.nativeToDenomination( | ||
| ? await request.fromWallet.convertNativeToDenominated( |
Contributor
There was a problem hiding this comment.
As mentioned in the core PR, we want to move these utilities into this repo, and then it would be nativeToDenomination(request.fromWallet, request.nativeAmount, request.fromTokenId)
swansontec
approved these changes
Dec 2, 2025
9749f42 to
b0e295c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-core-js#688
Description
noneNote
Replaces async wallet denomination calls with new synchronous helpers and migrates invalid-currency and same-asset logic to tokenId-based checks across swap plugins; bumps edge-core-js.
nativeToDenomination/denominationToNativeinutil/utilsand use them throughout.checkInvalidCodeswithcheckInvalidTokenIdsusing tokenIds (incl.nullfor parents); update helpers inutil/swapHelpers.changehero,changenow,exolix,godex,letsexchange,sideshift,swapuz):checkInvalidTokenIds; update invalid maps to tokenIds (e.g., Polygon USDC, VELO/MATH, Zcashnull).lifi,rango,swapkit,thorchainCommon,cosmosIbc,xrpDex):payoutTokenIdin Cosmos IBC; adjust ZEC handling to tokenId semantics.fromTokenId/toTokenIdfor validation.testpartner.tsto pass tokenIds and use new sync denomination helpers.edge-core-jsto^2.37.0.Written by Cursor Bugbot for commit b0e295c. This will update automatically on new commits. Configure here.