-
Notifications
You must be signed in to change notification settings - Fork 10
remove rb-nokogiri from conda environment and pin ruby > 3
#378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thanks @rswamina 🍺 |
|
@valeriupredoi - Only one reviewer approval is required. If you are happy, I will merge. |
|
ah sorry, old habit with @bouweandela in Core - I merged already 😁 |
|
Unfortunately, the new environment is not working for me. But the old one did. @valeriupredoi Do you know what the problem might be? Output after |
|
@LisaBock can you try with ruby==3.4.7 - that's the one it worked for me and Ranjini, if it does work, then I'll pin it in a PR - your conda/mamba may be a bit too old so it picked up 3.4.0 |
|
@valeriupredoi Sorry, this changed nothing... Same error. |
|
your bundler is ancient, currently at 2.7.2 https://rubygems.org/gems/bundler/versions/2.7.2?locale=en - try updating that one as well - I am on 2.6.9 in the test I ran and found nokogiri being ancient |
|
@LisaBock you really need to update your conda mamba base - your picking up some really ancient package versions, I just created the env on my local machine with: and my bundler is 2.6.9, with ruby 🍻 |
|
My versions are not old: When typing |
|
ah they are not old at all! How are you creating the environment then? |
|
it'd be good if you moved to eg Python 3.13 though, 3.9 is not supported anymore |
rb-nokogirifrom conda forge is ancient (last uploaded more than 4 years ago) and it's holding uprubyto a very old version; removing it here, and pinningruby >3that'll pick up a modern version. If Nokogiri really needs installation (I don't know where it's used), agem install nokogiriwill most probably do the trick.Nokogiri as a gem looks well maintained and released https://rubygems.org/gems/nokogiri/versions/1.18.10?locale=en
The issue manifests itself in a (rather poorly error coded) message seen by @rswamina in #359
Closes #359
Pull Request checklist
We appreciate your time and effort to improve the tutorial. Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution.
Before you start
Tasks
Lesson developmentsection in CONTRIBUTING.md and does not contain any spelling or grammatical errors.Lesson organizationandLesson formattingsections in CONTRIBUTING.md and does not contain any spelling or grammatical errors.make serve, alternativelymake docker-serve. Please see thePreviewing your changes locallysection in CONTRIBUTING.md for installation instructions.If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes {Link to the corresponding issue}