Skip to content

Conversation

@jdebacker
Copy link
Collaborator

This PR does three things:

  • Updates the method to read the JSON parameters file that is packaged with OG-ZAF in order to avoid deprecation warnings (this applies to 5 example run scripts)
  • Creates a function to read the default SAM file, which mean that the default SAM file will not be read in unless one is updating the input-output parameters. As it is currently, this file is read in anytime the ogzaf package is imported.
  • Modifies setup.py to make sure both the representative firm and multi-sector calibration JSON files are packaged with ogzaf

@jdebacker jdebacker requested a review from rickecon March 7, 2025 15:20
@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Project coverage is 59.86%. Comparing base (534e97d) to head (a56e3e1).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
ogzaf/input_output.py 68.42% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #89       +/-   ##
===========================================
+ Coverage   42.95%   59.86%   +16.90%     
===========================================
  Files          12       12               
  Lines         426      431        +5     
===========================================
+ Hits          183      258       +75     
+ Misses        243      173       -70     
Flag Coverage Δ
unittests 59.86% <79.31%> (+16.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jdebacker jdebacker merged commit e3ef5e8 into EAPD-DRB:main Mar 11, 2025
9 checks passed
@jdebacker jdebacker deleted the warnings branch March 11, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant