Update DR to fix Windows build warning #2570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates DR to 1cec2631a to pull in the fix for a drreg compiler warning which is breaking the build. Issue DynamoRIO/dynamorio#7739
Contributor
Author
|
The non-Windows failure looks like a real drmgr issue, at least with how the umbra allscales test is using it: a regression coming from DynamoRIO/dynamorio#7610 which is making drmgr not clean up at the final drmgr_exit() like it used to. |
Contributor
Author
|
Filed as DynamoRIO/dynamorio#7746 |
abhinav92003
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates DR to 92be9e40f to pull in the fix for a drreg compiler warning which is breaking the build,
along with the drmgr fix for the umbra_test_allscales failure.
Updates drmemory usage of several DR events to use drmgr instead to comply with drmgr changes.
Avoids some double-definitions of macros.
Issue DynamoRIO/dynamorio#7739