Skip to content

Conversation

@bangarumahesh22
Copy link

This PR adds a simple signal buffer example demonstrating a memory leak scenario in an ECE signal processing context. Verified using Dr. Memory.

@@ -0,0 +1,16 @@
#include <stdlib.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in #2567, I am a little confused: so you are proposing creating a new directory examples/? Will these be used in automated tests? What is the bigger picture here: could you file a feature issue in the tracker and describe the goal and link this PR to that new issue?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @derekbruening for reviewing this PR as well.

As I mentioned in #2567 and #2568, you're correct - this PR is also creating a new example file (examples/signal_buffer_leak.c), not editing an existing file.

I've responded to your questions about the bigger picture in the other PRs, and the same applies here:

Key points:

Proposal:

Since all three PRs suffer from the same issues, I'm proposing to:

  1. Close all three PRs as they weren't properly thought through
  2. If you think example files would benefit the project, I can file a feature request with:
    • Clear purpose and use cases
    • Integration plan with documentation/tests
    • Which examples would be most valuable
  3. Wait for maintainer feedback before creating any new PRs

I apologize for the confusion and for not following proper contribution procedures. Should I proceed with closing these PRs?

#include <stdlib.h>
#include <stdio.h>

#define SIGNAL_SIZE 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain in comments why this is called "signal": is this related to UNIX signals, or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants