Conversation
|
Blocked by #2310 |
Added the fixes to this PR after all. |
|
@derekbruening Not sure if you are aware that this PR is ready for review. No rush though as I am busy with work, so feel free to look at it at your convenience. |
derekbruening
left a comment
derekbruening
left a comment
There was a problem hiding this comment.
Are there any more tests or sample tools to add that use these new features?
| UMBRA_MAP_SCALE_UP_2X, /** 1 app byte to 2 shadow byte */ | ||
| UMBRA_MAP_SCALE_UP_4X, /** | ||
| * 1 app byte to 4 shadow bytes. | ||
| * Reserve regions not supported (applies only for 64-bit). |
There was a problem hiding this comment.
Does the user know what a "Reserve region" is? Not seeing it anywhere...ok it's right above in the new comments. Maybe point there?
There was a problem hiding this comment.
The doc you mentioned pertains to the same enum def. If I place a doxygen link, it's just going to take the reader to the enum.
|
Many thanks for the review. I have tested many of the features in my tools' code-bases. However, I'll write some quick sample tools and include them in this PR. |
johnfxgalea
changed the title
2 participants
Adds more scales to Umbra. In particular, the following scales are added:
Adds support for both 32-bit and 64-bit architectures.
Issue: #2283