Skip to content

Add reference files for end-to-end testing#2

Draft
arunkannawadi wants to merge 2 commits intomainfrom
reference
Draft

Add reference files for end-to-end testing#2
arunkannawadi wants to merge 2 commits intomainfrom
reference

Conversation

@arunkannawadi
Copy link
Member

No description provided.

@sidneymau
Copy link

From @aguinot:

Objects are drawn in order so you will draw only the first 10 objects in the list. Given that stars are at the end, you will not test some particular case regarding the PSF handling. If you want to limit the number of objects drawn you shoudl make sure that they are representative enough of all the cases.
Maybe a way to do that would be link this to a coverage test so we can check if critical part of the code are not covered by the test

Specify `image.nobjects: 10` so it is lighter to run in GitHub actions

Change output format from .fits.gz to .fits so that sha can be used to compare

Commit sha from updated hack output
@sidneymau
Copy link

N.B. hack.sha produced by

find output -type f -exec sha256sum {} \; > hack.sha

and you can validate new outputs with sha256sum -c hack.sha (will require dir format to be the same)

@aguinot
Copy link
Collaborator

aguinot commented Feb 16, 2026

From @aguinot:

Objects are drawn in order so you will draw only the first 10 objects in the list. Given that stars are at the end, you will not test some particular case regarding the PSF handling. If you want to limit the number of objects drawn you shoudl make sure that they are representative enough of all the cases.
Maybe a way to do that would be link this to a coverage test so we can check if critical part of the code are not covered by the test

Actually, there is another problem by limiting the number of objects particularly to small numbers. Given that there is a buffer defined around the image, you could end up in case where none of the objects are drawn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants