-
Notifications
You must be signed in to change notification settings - Fork 318
Add new Domain Connect template for Blink.new #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit introduces a new Domain Connect template for Blink, enabling users to configure their domains for website hosting, subdomains, and email services. The template includes various DNS record configurations such as A, CNAME, MX, TXT, and SPF records. ## Type of change - [x] New template ## How Has This Been Tested? - [x] Schema validated using JSON Schema - [x] Template functionality checked using Online Editor - [x] Template is checked using template linter - [x] Template file name follows the pattern `<providerId>.<serviceId>.json` ## Example variable values - `ip1`: Primary A record IP - `ip2`: Secondary A record IP - `host`: Subdomain name - `target`: CNAME destination - `verification`: Domain verification token - `mx1/mx2`: MX record servers - `spf`: SPF include rule - `dkim_selector/dkim_value`: DKIM key - `dmarc_email`: DMARC reporting email address
|
Linter OK: |
kerolasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. I left couple nits to the pull, please have a thought - or request a merge as-is.
|
@kerolasa @pawel-kow Appreciate the review and approval. If everything now looks good from your side, would you mind merging this PR when you get a chance? |
…iptions This commit refines the variable descriptions in the Domain Connect template for Blink, enhancing clarity for users. Changes include specifying primary and optional secondary A record IPs, and updating the subdomain variable for better understanding. ## Type of change - [x] Update to existing template ## How Has This Been Tested? - [x] Schema validated using JSON Schema - [x] Template functionality checked using Online Editor - [x] Template is checked using template linter - [x] Template file name follows the pattern `<providerId>.<serviceId>.json`
kerolasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
pawel-kow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thx
Description
This pull request introduces a new Domain Connect template for the Blink service, enabling automated DNS configuration for website hosting, subdomains, email, and domain verification. The template defines all required DNS records and variables for seamless integration
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverExample variable values
Use Case 1: Apex Domain Setup (Website Hosting)
Resulting Records:
_blink→blink-verify=abc123def456ghi789@→75.2.60.5@→99.83.231.61www→proxy.blink.newUse Case 2: Subdomain Setup
Resulting Records:
_blink→blink-verify=xyz789uvw456rst123app→proxy.blink.newUse Case 3: SSL Certificate Validation (ACM)
Resulting Records:
_abc123.example.com→_abc123.acm-validations.awsUse Case 4: Email Setup (Full Configuration)
Resulting Records:
@→mx1.mailprovider.com(priority 10)@→mx2.mailprovider.com(priority 20)@→include:mailprovider.comblink._domainkey→v=DKIM1; k=rsa; p=MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA..._dmarc→v=DMARC1; p=quarantine; rua=mailto:[email protected]Complete Test Data Object