Add GraphQL/ContextWriteInType cop#183
Merged
DmitryTsepelev merged 3 commits intoDmitryTsepelev:masterfrom Feb 14, 2026
Merged
Conversation
Add a new cop that detects writes to the `context` object in GraphQL type definitions. Writing to `context` mutates shared state across the query execution, which can lead to unexpected behavior. The cop detects `context[]=`, `context.merge!`, and `context.store` calls. It is disabled by default and scoped to type files. https://claude.ai/code/session_014TRTLxSorVoijGQoDJfSKV
Owner
|
Hey hey, LGTM! Could you please take a look at the rubocop failure? |
Contributor
Author
|
@DmitryTsepelev updated |
Owner
|
One last offence, just break the line into two :) |
Contributor
Author
|
Sorry I missed that. Should be good now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new cop that detects writes to the
contextobject in GraphQL type definitions. Writing tocontextmutates shared state across the query execution, which can lead to unexpected behavior.The cop detects
context[]=,context.merge!, andcontext.storecalls. It is disabled by default and scoped to type files.This is currently Disabled by default as it's a breaking change, but could be added to the list of on by default cops.
I think mutating the context in type is very error prone and should be avoided. I figured this should live in this gem, rather than just our code base.