feature/contextwindowclosedcheck #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+99
to
+101
|
|
||
| taskContext.markClosed(); | ||
|
|
|
|
||
| throw new CompletionException(e); | ||
| } finally { | ||
| taskContext.markClosed(); |
Member
There was a problem hiding this comment.
You should be careful with finally-blocks, since they are always executed, meaning #markClosed is executed twice in some cases.
Comment on lines
+65
to
+74
| @Override | ||
| public void checkUse() { | ||
| if (closed) { | ||
| throw new IllegalStateException("TaskContext used after task finished"); | ||
| } | ||
|
|
||
| if (Thread.currentThread() != owner) { | ||
| throw new IllegalStateException("TaskContext used from non-owner thread"); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Are you sure you want exceptions to be thrown in the default case?
Member
Author
There was a problem hiding this comment.
yes, this method will be overriden in dirtcore
|
|
||
| @Override | ||
| public @NonNull Session session() { | ||
| this.checkUse(); |
Member
There was a problem hiding this comment.
Keep in mind that this will not always work and is easily bypassed. Example:
Session session = context.session();
context.queue(() -> {
// do something involving the session
});
This ^ is how I usually structure my code.
AlphaConqueror
requested changes
Oct 26, 2025
Member
AlphaConqueror
left a comment
AlphaConqueror
left a comment
There was a problem hiding this comment.
Take a look at the comments, generally fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.