Skip to content

Conversation

@Dimillian
Copy link
Owner

Motivation

  • On Windows the app could spawn visible CMD windows when running git check-ignore during workspace polling, causing disruptive console popups.

Description

  • Add std_command in src-tauri/src/shared/process_core.rs to construct a std::process::Command with CREATE_NO_WINDOW applied on Windows so synchronous subprocesses run hidden.
  • Route the git check-ignore invocation in src-tauri/src/shared/git_ui_core/diff.rs through the new std_command helper so spawned git processes no longer open visible consoles.
  • Preserve existing tokio_command behavior for async spawns and apply the same Windows-safe logic for synchronous command usage.

Testing

  • Ran npm run typecheck which completed successfully.
  • Ran cd src-tauri && cargo check which failed in this container due to a missing system glib-2.0 development package and is unrelated to the change.

Codex Task

@Dimillian
Copy link
Owner Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Dimillian Dimillian merged commit cb92215 into main Feb 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant