Skip to content

Conversation

@shaw-baobao
Copy link
Contributor

@shaw-baobao shaw-baobao commented Feb 11, 2026

Summary

This PR fixes an iOS tab-state issue where selecting Codex/Git/Log could still end up with Home selected when no workspace was active.

Root Cause

useTabActivationGuard forced phone layouts without an active workspace back to home, overriding user tab selection for codex, git, and log.

Changes

  • Removed the phone-specific fallback-to-home logic in useTabActivationGuard.
  • Kept the tablet-specific guard unchanged (home/projects -> codex).
  • Updated the App.tsx callsite to match the simplified hook API.
  • Added regression tests to ensure:
    • phone mode does not force home for non-home tabs without a workspace
    • tablet mode still redirects home to codex

Validation

  • npm run lint
  • npm run typecheck
  • npm run test

@Dimillian
Copy link
Owner

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Dimillian Dimillian merged commit 0290aaf into Dimillian:main Feb 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants