Prevent deep pagination causing Solr trouble #386
Conversation
Code quality scoreUh oh! The code quality got worse for this PR! Better take a look!! 🚨
|
boost-tim
changed the title
app/models/supplejack_api/search.rb
Outdated
| **options.merge(model_class: klass.model_class, schema_class: klass.schema_class) | ||
| ) | ||
|
|
||
| @options = if options.present? && options['api_key'].present? |
There was a problem hiding this comment.
I think it would be better to check the role of the key rather than if it is present or not, the anonymous user does actually have a key and it gets used if you don't provide your own key.
There was a problem hiding this comment.
With this implementation if I knew the anonymous API key user (unlikely) I could get around it
richardmatthewsdev
left a comment
richardmatthewsdev
left a comment
There was a problem hiding this comment.
I think it would be worth looking at the roles functionality that we can do in the record schema and see if there is a way that we can change the limits based on the role, rather than lack of the API key in the params :)
| s.add_dependency 'kaminari' | ||
| s.add_dependency 'kaminari-mongoid' | ||
| s.add_dependency 'lazy_high_charts' | ||
| s.add_dependency 'mimemagic' |
There was a problem hiding this comment.
question: Will this break anything?
There was a problem hiding this comment.
@hapiben it's a good question, but I couldn't even run bundle install unless I removed it
boost-tim
force-pushed
the
tw/deep-pagination-limits
branch
from
37bdca3 to
b2af788
Compare
Acceptance Criteria
Notes