Conversation
Fix for #42 hdfmap_class.py - add __slots__ - add local_data and prefer_local as inputs to eval and format_hdf reloader_class.py - add __contains__ - add add_local() and live_mode() - add _local_data and _prefer_local_data attributes - use these in eval and format
eval_functions.py - replace expression.replace with ast.NodeTransformer method - add tests Tests don't pass as AST method incorrectly formats the strings. Will use regex instead.
eval_functions.py - replace expression.replace with regex method - add tests All tests pass
DanPorter
deleted the
42-multiple-instances-of-hdfloader-contain-the-same-local-namespace
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hdfmap_class.py
__slots__reloader_class.py
__contains__eval_functions.py
All tests pass