-
Notifications
You must be signed in to change notification settings - Fork 22
Properly configure the ARM64 Agent installer as an ARM64 package #1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Let maintainers know that an action is required on their side
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the Windows MSI packaging flow to correctly set the WixSharp installer platform (x64 vs arm64) based on build/CI inputs, supporting ARM64 agent installer generation.
Changes:
- Derive MSI platform (x64/arm64) from a
DAGENT_PLATFORMenvironment variable and wire it into the WixSharp project. - Update CI/packaging scripts to pass architecture into the MSI build via
DAGENT_PLATFORM. - Minor refactors/updates: use named parameters for feature definitions, rename UI field usage, bump NuGet versions, and ignore downloaded binaries.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| package/AgentWindowsManaged/Resources/Features.cs | Uses named arguments for Feature construction for clarity. |
| package/AgentWindowsManaged/Program.cs | Adds platform resolution from env var and applies it to WixSharp project platform; adjusts default artifact paths. |
| package/AgentWindowsManaged/Dialogs/FeaturesDialog.cs | Renames FeatureItem UI backing field usage from View to ViewModel. |
| package/AgentWindowsManaged/DevolutionsAgent.csproj | Updates NuGet package versions. |
| ci/tlk.ps1 | Exports DAGENT_PLATFORM from the recipe target architecture. |
| ci/package-agent-windows.ps1 | Adds mandatory -Architecture parameter and exports DAGENT_PLATFORM for the MSI build. |
| .gitignore | Ignores downloaded tun2socks.exe and wintun.dll. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
71ab6d8 to
543a6f3
Compare
CBenoit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We need to properly mark the ARM64 installer as an ARM64 package, or else it can be installed on an x64 system (leading to a broken install).
➕ some minor installer housekeeping