T1319739 - DataGrid - Columns are misaligned after adding a column at runtime #32283
+152
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug (T1319739) where DataGrid columns become misaligned after adding or removing a column at runtime when repaintChangesOnly is enabled. The fix ensures that a full repaint is triggered when the column count changes, preventing header and data cell misalignment.
Changes:
- Extracted repaint logic into a new
needFullRepaintmethod in the data controller - Added detection for column count changes to trigger full repaint
- Added integration tests for both adding and removing columns with
repaintChangesOnly=true
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/devextreme/js/__internal/grids/grid_core/data_controller/m_data_controller.ts |
Adds needFullRepaint method to detect when full grid repaint is needed, including when column count changes |
packages/devextreme/js/__internal/grids/grid_core/columns_controller/__tests__/columns_controller.integration.test.ts |
Adds integration tests verifying that adding/removing columns maintains correct alignment between headers and data cells |
dmirgaev
reviewed
Jan 23, 2026
| e.group = columnsController.getGroupDataSourceParameters(!dataSource.remoteOperations().grouping); | ||
| } | ||
|
|
||
| private needFullRepaint(optionNames, changeTypes) { |
Contributor
There was a problem hiding this comment.
Don't we have an agreement to name private methods with _?
Contributor
Author
There was a problem hiding this comment.
The modern code we write without underscore.
Earlier we wrote underscore to show the method is private but now we have Typescript and just the modifier "private")
...internal/grids/grid_core/columns_controller/__tests__/columns_controller.integration.test.ts
Show resolved
Hide resolved
Alyar666
approved these changes
Jan 27, 2026
Raushen
added a commit
to Raushen/DevExtreme
that referenced
this pull request
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.