List: custom properties should be accessible in groupTemplate arguments(T1319741) #32267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where custom properties on grouped data items were being lost in the List component. When users pass grouped data with custom properties (e.g., { key: 'Group 1', items: [...], customProp: 'value' }), these properties should be accessible in the groupTemplate callback and preserved in the data source.
Changes:
- Modified the grouped data converter to bypass transformation when group items contain additional properties beyond the standard
keyanditems - Added comprehensive test coverage for single groups, mixed groups, and groupTemplate access scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/data/data_converter/grouped.ts | Added property count check to skip data transformation when custom properties exist on group items, preserving them through the data pipeline |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js | Added three test cases to verify custom properties are preserved in grouped items and accessible in groupTemplate |
packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js
Show resolved
Hide resolved
dmlvr
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.