-
Notifications
You must be signed in to change notification settings - Fork 665
Scheduler: add new scroll api method #32190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduler: add new scroll api method #32190
Conversation
7b8e737 to
67cd482
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds a new API method overload to the Scheduler component's scrollTo method, allowing users to specify scroll alignment ('start' or 'center') when scrolling to a specific date.
Changes:
- Adds new
scrollTomethod signature that accepts an options object withgroup,allDay, andalignproperties - Implements alignment logic in the workspace scroll calculations (defaults to 'center' for backward compatibility)
- Adds comprehensive Jest tests for the workspace-level scrollTo functionality
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Adds new scrollTo method overload with options object parameter for dx.all bundle |
| packages/devextreme/js/ui/scheduler.d.ts | Adds new scrollTo method overload with JSDoc annotations and references new SchedulerScrollToAlign enum |
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space.ts | Implements align parameter in workspace scrollTo method to calculate scroll offsets based on alignment |
| packages/devextreme/js/__internal/scheduler/m_scheduler.ts | Adds type guard to distinguish between positional and options-object parameters, forwards align to workspace |
| packages/devextreme/js/__internal/scheduler/tests/workspace.base.test.ts | Adds comprehensive tests for workspace scrollTo with different alignment options |
packages/devextreme/js/__internal/scheduler/__tests__/workspace.base.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/scrollTo.tests.js
Show resolved
Hide resolved
c9d8617
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
87aa638 to
f1734b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
703c181 to
ad661de
Compare
No description provided.