-
-
Notifications
You must be signed in to change notification settings - Fork 31
feat: Users - Managed & OIDC #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Users - Managed & OIDC #55
Conversation
…ructs to model data. Signed-off-by: SolarFactories <[email protected]>
Signed-off-by: SolarFactories <[email protected]>
…nd OIDC user management, and current user. Signed-off-by: SolarFactories <[email protected]>
Signed-off-by: SolarFactories <[email protected]>
Signed-off-by: SolarFactories <[email protected]>
…returning pages, instead of lists - to match the data returned from API - as API endpoints are not paginated - also removed passing PageOptions due to not being paginated. Updated tests accordingly. Removed SubjectIdentifier in test for creating OIDCUser, as only username is used by API. Signed-off-by: SolarFactories <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: SolarFactories <[email protected]>
Signed-off-by: SolarFactories <[email protected]>
bilimuho05stack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help
Signed-off-by: SolarFactories <[email protected]>
nscuro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit about the health functions, otherwise looks good!
Signed-off-by: SolarFactories <[email protected]>
Signed-off-by: SolarFactories <[email protected]>
New Endpoint Bindings
HealthService.Health-GET /health.OIDCService.RemoveTeamMapping2-DELETE /api/v1/oidc/group/{groupUuid}/team/{teamUuid}/mapping.OIDCService.RemoveTeamMapping, which usesDELETE /api/v1/oidc/mapping/{uuid}from aOIDCMapping.UUID.OIDCService.GetAllUsers-GET /api/v1/user/oidc.OIDCService.CreateUser-PUT /api/v1/user/oidc.OIDCService.DeleteUser-DELETE /api/v1/user/oidc.OIDCService.Login-POST /api/v1/user/oidc/login.PermissionService.AddPermissionToUser-POST /api/v1/permission/{permission}/user/{username}.PermissionService.RemovePermissionFromUser-DELETE /api/v1/permission/{permission}/user/{username}.UserService.GetAllManaged-GET /api/v1/user/managed.UserService.CreateManaged-PUT /api/v1/user/managed.UserService.UpdateManaged-POST /api/v1/user/managed.UserService.DeleteManaged-DELETE /api/v1/user/managed.UserService.AddTeamToUser-POST /api/v1/user/{username}/membership.UserService.RemoveTeamFromUser-DELETE /api/v1/user/{username}/membership.UserService.GetSelf-GET /api/v1/user/self.UserService.UpdateSelf-POST /api/v1/user/self.Fixes
OIDCService.GetAllGroups, andOIDCService.GetAllTeamsOf.PageOptions, and not settingX-Total-Countresponse header.Misc
OIDCService.OIDCService,UserService,AboutService.-timeout 15mtomake test, due to pipeline timing out on tests.HealthServiceto contain Health check bindings.API Coverage
4.13.6from122 / 220(55.5%) to137 / 220(62.3%) on endpoints./healthis not counted in difference due to not being listed in/api/openapi.json.