Draft: Adds a Reach contract, Sell NFT for Degen (or other ASAs) #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degen-dhow
commented
May 13, 2022
| // returns info | ||
| console.log(t1,t2,p); | ||
| // nothing happens | ||
| return true; |
Member
Author
There was a problem hiding this comment.
Good example here, Buyer can acc swap, console does print NFT ID, ASA ID, and Price in ASA but nothing happens at return true but accSwap signature is accSwap: Fun([Token, Token, UInt], Bool),
There was a problem hiding this comment.
Got some advice from Nick to double check:
- no need to use await on line 61
- Line 62: also don't think you need the await here, can get the user stuck in the front end. He suggested using the backend.Buyer syntax as well, didn't think that the current syntax would work... backend.Buyer(c, {put interact object here});
There was a problem hiding this comment.
If you want to use the new syntax, I think it should be: c.p.Buyer({interact object}) with no await. The way it is now you make a copy of the contract handle (e.g. acct2.contract(backend, c.getInfo())). The c.getInfo() might need an await, but that whole part is unnecessary and would just reference you contract handle c
There was a problem hiding this comment.
Two other points:
- Interact object is missing methods, such as cancel
- The reach compiler and stdlib have different versions, use version 0.1.10-rc.4
degen-dhow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early, early draft for getting feedback on why Reach frontend is behaving the way it is. Mostly bad code, ignore.