Conversation
Member
|
If I read this right (haven't tested), interpolate will throw an IndexError unless you feed it an integer. This seems reasonable, but maybe we could catch it and return a more specific error. Or we could convert to int and warn? |
Member
|
This looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CardinalBasis class, which is a 1D basis of independent points with no differentiability. This may be useful for doing simulations with parameter dimensions, etc. The only supported operators are ConvertConstant, Interpolate (to extract a particular index), Integrate (discrete sum over entries), and Average (average over entries). I have tested it with an implementation of 2D RBC for running separate initial conditions simultaneously, but haven't put in any unit tests.