[Feature] Support customizing JVM memory options via JVM_OPTS environment variable#4545
Open
zhuxt2015 wants to merge 1 commit intoDataLinkDC:devfrom
Open
[Feature] Support customizing JVM memory options via JVM_OPTS environment variable#4545zhuxt2015 wants to merge 1 commit intoDataLinkDC:devfrom
zhuxt2015 wants to merge 1 commit intoDataLinkDC:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Previously, JVM memory options in auto.sh were hardcoded as -Xms512M -Xmx2048M -XX:PermSize=512M -XX:MaxPermSize=1024M, and the Dockerfile worked around this by using sed to replace
the values at image build time with container-aware settings (-XX:+UseContainerSupport).
This PR removes the sed hack and introduces a cleaner approach:
Benefits:
docker run -e JVM_OPTS="-Xms1g -Xmx4g" dinky:latest
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: