cpp_kong: use local git SHA for dev version when available#6697
Draft
adeshkumar1 wants to merge 1 commit intomainfrom
Draft
cpp_kong: use local git SHA for dev version when available#6697adeshkumar1 wants to merge 1 commit intomainfrom
adeshkumar1 wants to merge 1 commit intomainfrom
Conversation
When the plugin source in binaries/kong-plugin-ddtrace has a .git directory (e.g. cloned by CI or a developer), use its HEAD SHA for the dev version suffix instead of always fetching the latest commit from main via the GitHub API. This ensures the reported version accurately reflects the code being tested. Falls back to the GitHub API when .git is not present (e.g. when the source came from a .rock artifact or was copied without git).
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
binaries/kong-plugin-ddtracehas a.gitdirectory, use its HEAD SHA for the dev version suffix instead of always fetching from the GitHub API.gitis not present (e.g..rockartifacts or copies without git history)Problem
The version reported during system-tests was always using the latest commit SHA from
mainvia the GitHub API, even when testing a local override (PR branch, custom clone, etc.). This made the reported version misleading — it showed themainSHA while actually testing different code