Skip to content

Conversation

@bcmyers
Copy link
Contributor

@bcmyers bcmyers commented Jan 2, 2025

WIP

Copy link
Contributor Author

bcmyers commented Jan 2, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bcmyers bcmyers marked this pull request as ready for review January 2, 2025 19:31
@bcmyers bcmyers force-pushed the brian.myers/241230/misc_split branch from 16c2fe0 to 0527483 Compare January 2, 2025 19:51
@bcmyers bcmyers changed the title add formatting tests for go and markdown add formatting tests for go, markdown and yaml Jan 2, 2025
Copy link
Contributor

@joneshf-dd joneshf-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for Language Tools!

Comment on lines +17 to +34
format_multirun(
name = "format",
go = "@go_sdk//:bin/gofmt",
markdown = ":prettier",
starlark = "@buildifier_prebuilt//:buildifier",
yaml = "@aspect_rules_lint//format:yamlfmt",
)

format_test(
name = "format_test",
size = "small",
go = "@go_sdk//:bin/gofmt",
markdown = ":prettier",
no_sandbox = True,
starlark = "@buildifier_prebuilt//:buildifier",
workspace = "//:WORKSPACE",
yaml = "@aspect_rules_lint//format:yamlfmt",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: Heck yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants