generate UDP on outside interfaces #1722
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binding the udp socket to 127.0.0.1 prevents it from sending packages to outside localhost.
blt
reviewed
Jan 21, 2026
|
|
||
| tokio::select! { | ||
| conn = UdpSocket::bind("127.0.0.1:0"), if connection.is_none() => { | ||
| conn = UdpSocket::bind("0.0.0.0:0"), if connection.is_none() => { |
Collaborator
There was a problem hiding this comment.
I buy the motivation but what this suggests to me is that the socket for this generator and others should be default bound to localhost but configurable otherwise. I can put up a PR for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding the udp socket to 127.0.0.1 prevents it from sending packages to outside localhost.
What does this PR do?
Binding the udp socket to 127.0.0.1 prevents it from sending packages to outside localhost. This PR allows sending data to outside of the host
Motivation
What inspired you to submit this pull request?
Related issues
A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.
Additional Notes
Anything else we should know when reviewing?