-
Notifications
You must be signed in to change notification settings - Fork 13
NOMERGE - add gauge metrics & temporarily remove histogram ones #1719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Arpafaucon
wants to merge
2
commits into
main
Choose a base branch
from
greg/http_payload_size_metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d5befa to
20e625a
Compare
Author
|
Test run done today aws-vault exec smp -- bash bin/submit_to_cluster --team-id 60693115 --baseline 7.74.1 --comparison 7.75.0 --path-to-experiments ./experiments/regression/agentsimp --tags "purpose=test-lading" --replicas 2where
Got result + cat /var/folders/dl/2n3g00gs4n9d0333yr_jk8x00000gp/T/tmp.RN2Ps0Kt4x/outputs/report.md
# Regression Detector Results
[Metrics dashboard](https://app.datadoghq.com/dashboard/ykh-ua8-vcu/smp-regression-detector-capture-data----refined?fromUser=true&refresh_mode=paused&tpl_var_run-id%5B0%5D=6c8e61d8-3da0-4df3-a4dd-61472ebcc97f&view=spans&from_ts=1769531584000&to_ts=1769531594000&live=false)
[Target profiles](https://app.datadoghq.com/profiling/explorer?query=env%3Asingle-machine-performance%20service%3Adatadog-agent%20job_id%3A6c8e61d8-3da0-4df3-a4dd-61472ebcc97f&agg_m=count&agg_m_source=base&agg_t=count&fromUser=false&viz=stream&start=1769524384000&end=1769535194000&paused=true)
Run ID: 6c8e61d8-3da0-4df3-a4dd-61472ebcc97f
Baseline: 7.74.1
Comparison: 7.75.0
## Optimization Goals: ✅ No significant changes detected
<details>
<summary><h2>
Fine details of change detection per experiment
</h2></summary>
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|------|-------------------|--------------------|----------|----------------|--------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| ➖ | quality_gate_idle | memory utilization | +0.22 | [-0.10, +0.54] | 1 | [Logs](https://app.datadoghq.com/logs?query=experiment%3Aquality_gate_idle%20run_id%3A6c8e61d8-3da0-4df3-a4dd-61472ebcc97f&agg_m=count&agg_m_source=base&agg_q=%40span.url&agg_q_source=base&agg_t=count&fromUser=true&index=single-machine-performance-target-logs&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=time%2Cdesc&top_n=100&top_o=top&viz=stream&x_missing=true&from_ts=1769524384000&to_ts=1769535194000&live=false) [bounds checks dashboard](https://app.datadoghq.com/dashboard/vz3-jd5-bdi?fromUser=true&refresh_mode=paused&tpl_var_experiment%5B0%5D=quality_gate_idle&tpl_var_job_id%5B0%5D=6c8e61d8-3da0-4df3-a4dd-61472ebcc97f&view=spans&from_ts=1769531584000&to_ts=1769531594000&live=false) |
</details>
<details>
<summary><h2>
Bounds Checks: ✅ Passed
</h2></summary>
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|------|-------------------|--------------------|-------------------|--------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| ✅ | quality_gate_idle | intake_connections | 2/2 | 3 = 3 | [bounds checks dashboard](https://app.datadoghq.com/dashboard/vz3-jd5-bdi?fromUser=true&refresh_mode=paused&tpl_var_experiment%5B0%5D=quality_gate_idle&tpl_var_job_id%5B0%5D=6c8e61d8-3da0-4df3-a4dd-61472ebcc97f&view=spans&from_ts=1769531584000&to_ts=1769531594000&live=false) |
| ✅ | quality_gate_idle | memory_usage | 2/2 | 154.06MiB ≤ 175MiB | [bounds checks dashboard](https://app.datadoghq.com/dashboard/vz3-jd5-bdi?fromUser=true&refresh_mode=paused&tpl_var_experiment%5B0%5D=quality_gate_idle&tpl_var_job_id%5B0%5D=6c8e61d8-3da0-4df3-a4dd-61472ebcc97f&view=spans&from_ts=1769531584000&to_ts=1769531594000&live=false) |
</details>
<details>
<summary><h2>
Explanation
</h2></summary>
**Confidence level:** 90.00%
**Effect size tolerance:** |Δ mean %| ≥ 5.00%
Performance changes are noted in the **perf** column of each table:
* ✅ = significantly better comparison variant performance
* ❌ = significantly worse comparison variant performance
* ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
3. Its configuration does not mark it "erratic".
</details>My understanding at this point is that
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add gauges for
Charted course
as a newcomer, I need to write it down somewhere^^
histogram!calls commented outMotivation
cf https://datadoghq.atlassian.net/wiki/spaces/SMP/pages/5915967832/Target+Invariants
We want to investigate how
ladingcan increasingly check the correctness of the program under test.More specifically, this is the first step towards supporting target invariant checks on the target outputs
Related issues
not sure where it is stored, help needed