chore(telemetry): add dependency tracker for SCA telemetry reporting#17514
Conversation
Introduce DependencyTracker to manage dependency state, deduplication, and re-reporting logic for SCA telemetry. Refactor dependency collection out of the telemetry writer into a dedicated module. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ncy logic Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codeowners resolved as |
This comment has been minimized.
This comment has been minimized.
Performance SLOsComparing candidate avara1986/sca-telemetry-dependency-tracker (1f6aabc) with baseline main (240631e) 🟡 Near SLO Breach (1 suite)🟡 packagesupdateimporteddependencies - 24/24 (1 unstable)✅ import_manyTime: ✅ 155.941µs (SLO: <170.000µs -8.3%) vs baseline: -0.3% Memory: ✅ 41.093MB (SLO: <46.000MB 📉 -10.7%) vs baseline: +6.0% ✅ import_many_cachedTime: ✅ 123.076µs (SLO: <130.000µs -5.3%) vs baseline: +1.1% Memory: ✅ 40.634MB (SLO: <46.000MB 📉 -11.7%) vs baseline: +4.1% ✅ import_many_stdlibTime: ✅ 1.254ms (SLO: <1.750ms 📉 -28.3%) vs baseline: +0.3% Memory: ✅ 41.113MB (SLO: <46.000MB 📉 -10.6%) vs baseline: +5.0%
|
The appsec architecture tests reference update_imported_dependencies which was moved from writer.py to dependency_tracker.py. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
f6f5a4c to
1f6aabc
Compare
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f6aabcdf3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Summary
This PR extracts the telemetry dependency tracking changes from the larger SCA PR (#17156) to reduce its size and make review more manageable.
DependencyTrackerto manage dependency state, deduplication, and re-reporting logic for SCA telemetrypackages_update_imported_dependenciesParent PR: #17156 —
feat(sca): runtime SCA reachabilityTest plan
tests/telemetry/test_dependency.pytests passtests/telemetry/test_data.pytests passChecklist
🤖 Generated with Claude Code