Fix SLO update via dogshell#889
Merged
jack-edmonds-dd merged 3 commits intoDataDog:masterfrom Nov 4, 2025
Merged
Conversation
|
This issue has been automatically marked as stale because it has not had activity in the last 30 days. |
jack-edmonds-dd
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The SLO update is broken. The server side will always return this error no matter the inputs:
Also, during SLO updates, name argument is ignored.
This PR fixes both issues.
Description of the Change
We transform the thresholds
targetstring to float, just like in the SLO creation. The DataDog API expects a number in the json body, not a string. We also add the name argument to the parameters of the request.Alternate Designs
N/A
Possible Drawbacks
None. Probably this never worked and clients are not depending on it.
Verification Process
Empirically on my computer.
Additional Notes
N/A
Release Notes
Fix SLO update via dogshell. This fixes a bug in dogshell that always produced
ERROR: Invalid payload: 'target' should be numbererror during SLO updates, and also takes into account the name argument.Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.