Upgrade karpenter-provider-aws from v1.3.6 to v1.9.0#2888
Upgrade karpenter-provider-aws from v1.3.6 to v1.9.0#2888
Conversation
Align karpenter-provider-aws with sigs.k8s.io/karpenter which was already at v1.9.0. This is the latest version compatible with Go 1.25.x (v1.10.0+ requires Go 1.26.x). Changes: - Upgrade github.com/aws/karpenter-provider-aws v1.3.6 → v1.9.0 - Add Windows Server 2025 AMI family support (available since v1.9.0) - Add replace directive for olekukonko/tablewriter to work around a transitive breaking API change (matching karpenter's own workaround) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests for detectAMIFamilyFromImage() and amiFamilyToAlias() covering all supported AMI families including the new Windows2025 support. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Run go work sync and go mod tidy on test/e2e to align the aws-sdk-go-v2/service/eks transitive dependency (v1.74.0 → v1.77.0) with the main module after the karpenter-provider-aws upgrade. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
New transitive dependency introduced by karpenter-provider-aws v1.9.0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2888 +/- ##
==========================================
+ Coverage 40.06% 40.18% +0.12%
==========================================
Files 319 319
Lines 28039 28043 +4
==========================================
+ Hits 11233 11270 +37
+ Misses 15983 15950 -33
Partials 823 823
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
🎯 Code Coverage (details) 🔗 Commit SHA: 52f7b9e | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
What does this PR do?
Upgrades
github.com/aws/karpenter-provider-awsfrom v1.3.6 to v1.9.0, aligning it withsigs.k8s.io/karpenterwhich was already at v1.9.0.Also adds Windows Server 2025 AMI family support, which became available in Karpenter v1.9.0.
Motivation
The karpenter-provider-aws Go module was 6 minor versions behind sigs.k8s.io/karpenter. v1.9.0 is the latest version compatible with the project's Go 1.25.x toolchain (v1.10.0+ requires Go 1.26.x).
Additional Notes
replacedirective was added forolekukonko/tablewriter(v1.1.0 → v0.0.5) because karpenter-provider-aws v1.9.0 transitively pulls in tablewriter v1.1.0 which has a breaking API change. This matches the same workaround in karpenter-provider-aws's own go.mod.karpenter.yaml,dd-karpenter.yaml) are unchanged because the upstream CF template at v1.9.0 is identical to v1.3.x. The IAM policy restructuring (single policy → 5 policies) only happened in v1.10.0+.nodegroupproperties.gowas not updated for Windows 2025 because the AWS SDK doesn't yet define Windows 2025 EKS AMI type constants; the existingdefaultfallback handles future additions.Minimum Agent Versions
N/A — this change affects the
kubectl datadog autoscaling cluster installplugin only.Describe your test plan
go build ./...passesgo test ./cmd/kubectl-datadog/autoscaling/cluster/...passes (all 4 test packages OK)kubectl datadog autoscaling cluster installon an EKS clusterChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel🤖 Generated with Claude Code