Skip to content

Upgrade karpenter-provider-aws from v1.3.6 to v1.9.0#2888

Open
L3n41c wants to merge 5 commits intomainfrom
lenaic/upgrade-karpenter-provider-aws-v1.9.0
Open

Upgrade karpenter-provider-aws from v1.3.6 to v1.9.0#2888
L3n41c wants to merge 5 commits intomainfrom
lenaic/upgrade-karpenter-provider-aws-v1.9.0

Conversation

@L3n41c
Copy link
Copy Markdown
Member

@L3n41c L3n41c commented Apr 10, 2026

What does this PR do?

Upgrades github.com/aws/karpenter-provider-aws from v1.3.6 to v1.9.0, aligning it with sigs.k8s.io/karpenter which was already at v1.9.0.

Also adds Windows Server 2025 AMI family support, which became available in Karpenter v1.9.0.

Motivation

The karpenter-provider-aws Go module was 6 minor versions behind sigs.k8s.io/karpenter. v1.9.0 is the latest version compatible with the project's Go 1.25.x toolchain (v1.10.0+ requires Go 1.26.x).

Additional Notes

  • A replace directive was added for olekukonko/tablewriter (v1.1.0 → v0.0.5) because karpenter-provider-aws v1.9.0 transitively pulls in tablewriter v1.1.0 which has a breaking API change. This matches the same workaround in karpenter-provider-aws's own go.mod.
  • The CloudFormation templates (karpenter.yaml, dd-karpenter.yaml) are unchanged because the upstream CF template at v1.9.0 is identical to v1.3.x. The IAM policy restructuring (single policy → 5 policies) only happened in v1.10.0+.
  • nodegroupproperties.go was not updated for Windows 2025 because the AWS SDK doesn't yet define Windows 2025 EKS AMI type constants; the existing default fallback handles future additions.

Minimum Agent Versions

N/A — this change affects the kubectl datadog autoscaling cluster install plugin only.

Describe your test plan

  • go build ./... passes
  • go test ./cmd/kubectl-datadog/autoscaling/cluster/... passes (all 4 test packages OK)
  • Manual testing with kubectl datadog autoscaling cluster install on an EKS cluster

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

🤖 Generated with Claude Code

Align karpenter-provider-aws with sigs.k8s.io/karpenter which was already
at v1.9.0. This is the latest version compatible with Go 1.25.x (v1.10.0+
requires Go 1.26.x).

Changes:
- Upgrade github.com/aws/karpenter-provider-aws v1.3.6 → v1.9.0
- Add Windows Server 2025 AMI family support (available since v1.9.0)
- Add replace directive for olekukonko/tablewriter to work around a
  transitive breaking API change (matching karpenter's own workaround)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@L3n41c L3n41c added the dependencies Pull requests that update a dependency file label Apr 10, 2026
Tests for detectAMIFamilyFromImage() and amiFamilyToAlias() covering
all supported AMI families including the new Windows2025 support.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@L3n41c L3n41c added this to the v1.27.0 milestone Apr 10, 2026
Run go work sync and go mod tidy on test/e2e to align the
aws-sdk-go-v2/service/eks transitive dependency (v1.74.0 → v1.77.0)
with the main module after the karpenter-provider-aws upgrade.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@L3n41c
Copy link
Copy Markdown
Member Author

L3n41c commented Apr 10, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

New transitive dependency introduced by karpenter-provider-aws v1.9.0.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.18%. Comparing base (5adfc81) to head (52f7b9e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2888      +/-   ##
==========================================
+ Coverage   40.06%   40.18%   +0.12%     
==========================================
  Files         319      319              
  Lines       28039    28043       +4     
==========================================
+ Hits        11233    11270      +37     
+ Misses      15983    15950      -33     
  Partials      823      823              
Flag Coverage Δ
unittests 40.18% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...toscaling/cluster/install/guess/nodesproperties.go 12.65% <100.00%> (+12.65%) ⬆️
...og/autoscaling/cluster/install/k8s/ec2nodeclass.go 18.82% <100.00%> (+18.82%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5adfc81...52f7b9e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-prod-us1-5
Copy link
Copy Markdown

datadog-prod-us1-5 bot commented Apr 10, 2026

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 40.28%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 52f7b9e | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@L3n41c L3n41c marked this pull request as ready for review April 13, 2026 16:05
@L3n41c L3n41c requested a review from a team April 13, 2026 16:05
@L3n41c L3n41c requested a review from a team as a code owner April 13, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants