Skip to content

Add DPACP to orchestrator explorer OOTB CRD collection#2887

Closed
clamoriniere wants to merge 1 commit intomainfrom
clamoriniere/add-dpacp-crd-support
Closed

Add DPACP to orchestrator explorer OOTB CRD collection#2887
clamoriniere wants to merge 1 commit intomainfrom
clamoriniere/add-dpacp-crd-support

Conversation

@clamoriniere
Copy link
Copy Markdown
Collaborator

@clamoriniere clamoriniere commented Apr 9, 2026

What does this PR do?

Add DPACP CRD collection support in the orchestrator explorer feature.

Motivation

make the the DPACP CR collected OOTB to each autoscaling product onboarding

Additional Notes

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@clamoriniere clamoriniere requested a review from a team April 9, 2026 22:14
@clamoriniere clamoriniere requested a review from a team as a code owner April 9, 2026 22:14
@clamoriniere clamoriniere added this to the v1.26.0 milestone Apr 9, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.06%. Comparing base (5adfc81) to head (6bd7eca).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2887   +/-   ##
=======================================
  Coverage   40.06%   40.06%           
=======================================
  Files         319      319           
  Lines       28039    28040    +1     
=======================================
+ Hits        11233    11234    +1     
  Misses      15983    15983           
  Partials      823      823           
Flag Coverage Δ
unittests 40.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tadogagent/feature/orchestratorexplorer/feature.go 72.14% <100.00%> (+0.20%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5adfc81...6bd7eca. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clamoriniere clamoriniere requested a review from a team April 9, 2026 22:43
@vboulineau
Copy link
Copy Markdown
Contributor

This should not be required anymore, should be part of: https://github.com/DataDog/datadog-agent/blob/main/pkg/collector/corechecks/cluster/orchestrator/collector_bundle.go#L530

Only RBACs needed (should be covered already)

@clamoriniere clamoriniere added enhancement New feature or request and removed bug Something isn't working labels Apr 10, 2026
@clamoriniere
Copy link
Copy Markdown
Collaborator Author

This should not be required anymore, should be part of: https://github.com/DataDog/datadog-agent/blob/main/pkg/collector/corechecks/cluster/orchestrator/collector_bundle.go#L530

Only RBACs needed (should be covered already)

Yes RBAC are ok since we allow all resources for list, watch in the datadoghq.com apigroup

for the default collector configuration, I don't see the new resource par of the OOTB CRD, I will add them

@clamoriniere
Copy link
Copy Markdown
Collaborator Author

We can close this PR since the best way to add DPACP CR collection OOTB is to do a PR in https://github.com/DataDog/datadog-agent/blob/main/pkg/collector/corechecks/cluster/orchestrator/collector_bundle.go#L530 as suggested by @vboulineau

@tbavelier tbavelier deleted the clamoriniere/add-dpacp-crd-support branch April 10, 2026 09:36
@clamoriniere
Copy link
Copy Markdown
Collaborator Author

PR on datadog-agent repo DataDog/datadog-agent#49167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants