Add DPACP to orchestrator explorer OOTB CRD collection#2887
Add DPACP to orchestrator explorer OOTB CRD collection#2887clamoriniere wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2887 +/- ##
=======================================
Coverage 40.06% 40.06%
=======================================
Files 319 319
Lines 28039 28040 +1
=======================================
+ Hits 11233 11234 +1
Misses 15983 15983
Partials 823 823
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This should not be required anymore, should be part of: https://github.com/DataDog/datadog-agent/blob/main/pkg/collector/corechecks/cluster/orchestrator/collector_bundle.go#L530 Only RBACs needed (should be covered already) |
Yes RBAC are ok since we allow all resources for list, watch in the datadoghq.com apigroup for the default collector configuration, I don't see the new resource par of the OOTB CRD, I will add them |
|
We can close this PR since the best way to add DPACP CR collection OOTB is to do a PR in https://github.com/DataDog/datadog-agent/blob/main/pkg/collector/corechecks/cluster/orchestrator/collector_bundle.go#L530 as suggested by @vboulineau |
|
PR on datadog-agent repo DataDog/datadog-agent#49167 |
What does this PR do?
Add DPACP CRD collection support in the orchestrator explorer feature.
Motivation
make the the DPACP CR collected OOTB to each autoscaling product onboarding
Additional Notes
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel