Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 506f9a8 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
|
I have read the CLA Document and I hereby sign the CLA |
Clean up file header comment and fix markdown heading level in shadow PR body. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
I have read the CLA Document and I hereby sign the CLA |
| echo "=== Mirroring PR #${PR_NUMBER} (${PR_HEAD_SHA}) to ${SHADOW_FORK} ===" | ||
|
|
||
| # Determine version number by counting existing shadow branches (exclude -base) | ||
| VERSION=$(git ls-remote --heads "https://x-access-token:${SHADOW_FORK_TOKEN}@github.com/${SHADOW_FORK}.git" "shadow/${PR_NUMBER}/v*" 2>/dev/null \ |
There was a problem hiding this comment.
I think it is better to use dd-octo-sts for the GH token management
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 506f9a869d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if: >- | ||
| github.event_name == 'pull_request' | ||
| && github.event.pull_request.draft != true | ||
| && github.event.pull_request.user.type != 'Bot' |
There was a problem hiding this comment.
Skip job when shadow token is unavailable on fork PRs
This job runs for all non-draft, non-bot pull_request events, but it assumes secrets.SHADOW_FORK_TOKEN is present and immediately uses it for shadow-fork access. For forked PRs (and Dependabot-style fork-restricted runs), repository secrets are not provided, so the pre-flight check fails and the workflow reports a hard failure for external contributors. Add a guard in if: (for example, same-repo PRs only) or explicitly skip when the token is missing.
Useful? React with 👍 / 👎.
| git fetch origin "pull/${PR_NUMBER}/head:pr-head" --depth=50 | ||
| echo "Fetching base ref..." | ||
| git fetch origin "${PR_BASE_REF}:base-ref" --depth=50 |
There was a problem hiding this comment.
Fetch enough history before calling merge-base
Both refs are fetched with a fixed shallow depth of 50 and then used to compute git merge-base. When a PR branch diverged more than 50 commits ago, the common ancestor is outside the fetched history, so git merge-base fails and the mirror job aborts for long-lived branches. This should deepen/fetch full history (or retry with increasing depth) before deriving MERGE_BASE.
Useful? React with 👍 / 👎.
|
Going to merge and address the feedback in a new PR |

Motivation
Add a GitHub Actions workflow for shadow code review powered by the rum-ai-toolkit shadow reviewer.
Changes
.github/workflows/shadow-review.ymlworkflow that:Test instructions
Workflow will trigger on PRs — verify it runs correctly on a test PR.
Checklist
🤖 Generated with Claude Code