Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 3c68128 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
|
Also, blocked until PR is merged. |
|
@codex pls review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 788dd91732
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 788dd91732
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Motivation
The plugin E2E test scenarios (Angular, Vue, React, Next.js) were duplicated across each framework's scenario file. Every plugin tested the same core router behaviors but each had its own copy.
Changes
Extracted the 6 common plugin test scenarios into
test/e2e/scenario/plugins/basePluginTests.ts:The base tests are:
Reorganized all plugin scenario files into a
test/e2e/scenario/plugins/subdirectory (angular,vue,react,nextjs,plugin).Replaced
id-based element selectors (#error-button) withdata-testidattributes across all test apps.Framework-specific tests that don't fit the shared suite remain in their own
test.describeblocks (Angular nested routes / wildcard / error handler, React splat routes / vital events / error boundary details, Next.js parallel routes / server errors / global errors).Removed all unused code from the tests apps.
Removed the firefox check on React tests.
Test instructions
Verify that all shared scenarios (initial load, dynamic route normalization, SPA loading time, hash-only nav, query-param-only nav, same-route different URLs, client error) pass for each framework.
Checklist