Skip to content

Conversation

@MMilosz
Copy link
Contributor

@MMilosz MMilosz commented Jan 25, 2026

References

Description

This PR applies the recommended fix from Hadolint DL3019 rule:

https://github.com/hadolint/hadolint/wiki/DL3019

Instructions for Reviewers

  1. Remove existing DSpace Docker images (either use Docker Desktop, or use CLI commands: docker images, find image ID, do docker rmi <IMAGE_ID>
  2. Refer to DSpace documentation on how to build each Docker image locally. Or, make use of Docker Compose:
    $ docker compose -p d10 -f docker/docker-compose.yml build --no-cache
    $ docker compose -p d10 -f docker/docker-compose.yml up

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

-  DL3019 info: Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages
@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker labels Jan 26, 2026
@tdonohue tdonohue added this to the 10.0 milestone Jan 26, 2026
@tdonohue tdonohue self-requested a review January 26, 2026 15:06
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jan 26, 2026
@tdonohue tdonohue added the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Jan 27, 2026
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @MMilosz ! This looks good to me. I also briefly tested both images and they both work the same as before.

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Jan 28, 2026
@tdonohue tdonohue merged commit e30b69c into DSpace:main Jan 28, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Jan 28, 2026
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-9_x:

@tdonohue tdonohue removed the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Jan 28, 2026
@tdonohue
Copy link
Member

NOTE: At this time, this has only been ported to 9.x because older versions used yarn. They would have to be manually backported (if we decide to do so) as the syntax for yarn is slightly different than npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker code task

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants