Skip to content

Conversation

@kshepherd
Copy link
Member

@kshepherd kshepherd commented Apr 7, 2025

The preview link was showing an outdated routing path (/access-by-token) instead of the newer, simple item page path with a query parameter.
This small PR fixes that issue and removes some obsolete routing code.

References

List of changes in this PR:

  • Build item page + query param route in the grant-request-copy component
  • Remove outdated access-by-token routing method and path constant

To test, visit the 'grant request' page form with secure links enabled, after requesting an item, and ensure the preview link looks valid (note - it won't work yet as the access hasn't been granted at the time of viewing the form! it's just there for preview / copy paste purposes)

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR fixes an issue ticket, I've linked them together.

Preview link was showing old URL path
in grant access form
@kshepherd kshepherd added the bug label Apr 7, 2025
@kshepherd kshepherd added the 1 APPROVAL pull request only requires a single approval to merge label Apr 7, 2025
@tdonohue tdonohue self-requested a review April 7, 2025 14:26
@tdonohue tdonohue moved this to 👀 Under Review in DSpace 9.0 Release Apr 7, 2025
@tdonohue tdonohue added this to the 9.0 milestone Apr 7, 2025
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @kshepherd ! I verified the bug & verified this fixes it.

@github-project-automation github-project-automation bot moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 9.0 Release Apr 8, 2025
@tdonohue tdonohue merged commit bd4c6d6 into DSpace:main Apr 8, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 9.0 Release Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants