Open
Conversation
The default max_routes for new VRFs was previously set via the GROUT_MAX_ROUTES_DEFAULT environment variable, parsed at init time. Replace this with a runtime API option by accepting "default" in place of a VRF name in the route config set command. When vrf_id is GR_VRF_ID_UNDEF, the handler updates the default max_routes used for subsequently created VRFs instead of reconfiguring an existing one. This also removes the parse_uint call from route4_init/route6_init and the GROUT_MAX_ROUTES_DEFAULT env var from smoke tests, replacing it with "grcli route config set default rib4-routes 128 rib6-routes 128". Signed-off-by: Robin Jarry <rjarry@redhat.com>
This comment was marked as resolved.
This comment was marked as resolved.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
christophefontaine
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default max_routes for new VRFs was previously set via the GROUT_MAX_ROUTES_DEFAULT environment variable, parsed at init time. Replace this with a runtime API option by accepting "default" in place of a VRF name in the route config set command. When vrf_id is GR_VRF_ID_UNDEF, the handler updates the default max_routes used for subsequently created VRFs instead of reconfiguring an existing one.
This also removes the parse_uint call from route4_init/route6_init and the GROUT_MAX_ROUTES_DEFAULT env var from smoke tests, replacing it with "grcli route config set default rib4-routes 128 rib6-routes 128".
Summary by CodeRabbit
New Features
Bug Fixes
Documentation